Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Disallow calling functions without type annotations from functions with type annotation #8246

Closed
3 tasks done
wochinge opened this issue Mar 18, 2021 · 1 comment · Fixed by #8276
Closed
3 tasks done

mypy: Disallow calling functions without type annotations from functions with type annotation #8246

wochinge opened this issue Mar 18, 2021 · 1 comment · Fixed by #8276
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Mar 18, 2021 •
edited
Loading

Parent issue

To enforce type annotations which should start running mypy with the --disallow-untyped-calls flag.
This currently causes: 50 issues

Definition of Done:

  • the Rasa Open Source CI runs make types with the --disallow-untyped-calls
  • all detected mypy issues are fixed
  • report time taken to squad
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 18, 2021
@wochinge wochinge mentioned this issue Mar 18, 2021
Closed
2 tasks
@wochinge wochinge added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Mar 19, 2021
@wochinge
Copy link
Contributor Author

It took me 45 minutes. Mostly because there was an issue with a library of ours, and installing the stubs didn't work and I had to define them myself.

@wochinge wochinge mentioned this issue Mar 26, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow calls to untyped functions RasaHQ/rasa
1 participant
@wochinge