Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy return-value error code #9095

Closed
2 tasks
wochinge opened this issue Jul 12, 2021 · 1 comment
Closed
2 tasks

Enable mypy return-value error code #9095

wochinge opened this issue Jul 12, 2021 · 1 comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 97

Definition of Done:

  • enable mypy checks for [return-value]
  • all existing [return-value] issues are fixed
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 12, 2021
@wochinge wochinge mentioned this issue Jul 12, 2021
Closed
2 tasks
@wochinge
Copy link
Contributor Author

Fixed by #9109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wochinge