Added comments for L1 control parameters #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed a few things and merged this into the param_docs branch, please continue discussion in #671. |
PX4BuildBot
pushed a commit
that referenced
this pull request
Jul 7, 2018
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/px4-master_auto_rebase - PX4/NuttX@122f673 Changes from PX4-NuttX/nuttx (PX4/NuttX@d5c12b2) in current PX4/master (dec0387) PX4/NuttX@d5c12b2...122f673 122f673 (HEAD, origin/px4-master_auto_rebase) [PX4: WIP] Fix transmission status handling in the serial interrupt dc6a926 [PX4: REJECTED] cstdint fix 37fc336 [PX4: REJECTED] add math.h 506547a [PX4: WIP] Jenkinsfile 078fd78 (origin/master) Merged in raiden00/nuttx (pull request #669) 8416d9a Merged in raiden00/nuttx (pull request #668) 3cd1ccf configs/viewtool-stm32f107/tcpblaster: Configuration modified to use the low-priority work queue. Actually ALL network configuration should be modified to use the low priority work queue. It is inappropriate to be performing network operations on the high priority work queue. 427b3b8 Squashed commit of the following: 75cc19e net/tcp: Fix a deadlock condition that can occur when (1) all network logic runs on a single work queue, (1) TCP write buffering is enabled, and (2) we run out of IOBs. In this case, the TCP write buffering logic was blocking on iob_alloc() with the network locked. Since the network was locked, the device driver polls that would provide take the write buffer data and release the IOBs could not execute. This fixes the problem by unlocking the network lock while waiting for the IOBs. 23a8af2 Trivial update to some comments. Apps: - https://github.com/PX4-NuttX/apps/tree/px4-master_auto_rebase - PX4/NuttX-apps@444ee16 Changes from PX4-NuttX/apps (PX4/NuttX-apps@36806ba) in current PX4/master (dec0387) PX4/NuttX-apps@36806ba...444ee16 444ee16 (HEAD -> px4-master_auto_rebase, origin/px4-master_auto_rebase) [REJECTED] add-var-expansion-in-nsh-parse.patch e66470d (origin/master) Merged in raiden00/apps (pull request #143) db77b1e apps/examples/tcpblaster: Fix an error in time calculation. 19b8a52 apps/examples/tcpblaster/tcpblaster_server.c: Start time was not being initialized on the server side on the first pass through loop so the first output record had a crazy time. 749eccb Squashed commit of the following: 4d8b8fa apps/netutils/dhcpc: Activates BINDTODEVICE if available, and break up some long lines 0abe341 Merged in raiden00/apps (pull request #142) 3403b1b apps/nshlib/README.txt: Clarify arguments to the mkrd command. abcb66c Remove apps/interpreters/micropthon. There are several reasons for this. (1) the current version 1.3.8 is very old and no one is supporting it. (2) the port only includes the core micropython logic and none of the Python libraries. As such it is useless in any real application. (3) There have recently been compile failures reported. It looks like this is due to changes in newlib based toolchains that now bring in incompatible newlib header files. See issue 104 at https://bitbucket.org/nuttx/nuttx/issues/104/build-micropython-138-error. With no one dedicated to the support of micropython, it can no longer be carried in the NuttX apps/ repository. 36d6348 apps/nslib: Try to eliminate and uninitialized variable warning.
PX4BuildBot
pushed a commit
that referenced
this pull request
Jul 7, 2018
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/px4-master_auto_rebase - PX4/NuttX@e61ee7d Changes from PX4-NuttX/nuttx (PX4/NuttX@d5c12b2) in current PX4/master (dec0387) PX4/NuttX@d5c12b2...e61ee7d e61ee7d (HEAD, origin/px4-master_auto_rebase) [PX4: WIP] Fix transmission status handling in the serial interrupt 5f74d4c [PX4: REJECTED] cstdint fix 79ae4c6 [PX4: REJECTED] add math.h 7aea643 [PX4: WIP] Jenkinsfile a764e4a (origin/master) drivers/leds/pca9635pw.c configs/stm32f4discovery/src/stm32_pca9635.c: Fix pca9635pw LED driver compilation 1450c0c arch/arm/src/stm32f7/stm32_sdmmc.c: Fix some missing right parentheses. 6571d4f Update some comments. 078fd78 Merged in raiden00/nuttx (pull request #669) 8416d9a Merged in raiden00/nuttx (pull request #668) 3cd1ccf configs/viewtool-stm32f107/tcpblaster: Configuration modified to use the low-priority work queue. Actually ALL network configuration should be modified to use the low priority work queue. It is inappropriate to be performing network operations on the high priority work queue. Apps: - https://github.com/PX4-NuttX/apps/tree/px4-master_auto_rebase - PX4/NuttX-apps@444ee16 Changes from PX4-NuttX/apps (PX4/NuttX-apps@36806ba) in current PX4/master (dec0387) PX4/NuttX-apps@36806ba...444ee16 444ee16 (HEAD -> px4-master_auto_rebase, origin/px4-master_auto_rebase) [REJECTED] add-var-expansion-in-nsh-parse.patch e66470d (origin/master) Merged in raiden00/apps (pull request #143) db77b1e apps/examples/tcpblaster: Fix an error in time calculation. 19b8a52 apps/examples/tcpblaster/tcpblaster_server.c: Start time was not being initialized on the server side on the first pass through loop so the first output record had a crazy time. 749eccb Squashed commit of the following: 4d8b8fa apps/netutils/dhcpc: Activates BINDTODEVICE if available, and break up some long lines 0abe341 Merged in raiden00/apps (pull request #142) 3403b1b apps/nshlib/README.txt: Clarify arguments to the mkrd command. abcb66c Remove apps/interpreters/micropthon. There are several reasons for this. (1) the current version 1.3.8 is very old and no one is supporting it. (2) the port only includes the core micropython logic and none of the Python libraries. As such it is useless in any real application. (3) There have recently been compile failures reported. It looks like this is due to changes in newlib based toolchains that now bring in incompatible newlib header files. See issue 104 at https://bitbucket.org/nuttx/nuttx/issues/104/build-micropython-138-error. With no one dedicated to the support of micropython, it can no longer be carried in the NuttX apps/ repository. 36d6348 apps/nslib: Try to eliminate and uninitialized variable warning.
PX4BuildBot
pushed a commit
that referenced
this pull request
Jul 8, 2018
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/px4-master_auto_rebase - PX4/NuttX@9874e65 Changes from PX4-NuttX/nuttx (PX4/NuttX@d5c12b2) in current PX4/master (dec0387) PX4/NuttX@d5c12b2...9874e65 9874e65 (HEAD, origin/px4-master_auto_rebase) [PX4: WIP] Fix transmission status handling in the serial interrupt e1825e3 [PX4: REJECTED] cstdint fix 4a6c13c [PX4: REJECTED] add math.h 32de998 [PX4: WIP] Jenkinsfile 9e63080 (origin/master) Merged in raiden00/nuttx/stm32h7 (pull request #670) 70dc642 The LPC54608 can only run at a maximum frequency of 180Mhz. This configuration requires uses the clk_in, external crystal clock, to drive the PLL. When that input was selected, the board bootup failed waiting for the PLL to lock. After referring the driver from NXP, we should turn on power sources for the ext clock if system pll input select clk_in. NOTE that the LPC54628 did not require this step... perhaps because the system oscillator power was already enabled. a764e4a drivers/leds/pca9635pw.c configs/stm32f4discovery/src/stm32_pca9635.c: Fix pca9635pw LED driver compilation 1450c0c arch/arm/src/stm32f7/stm32_sdmmc.c: Fix some missing right parentheses. 6571d4f Update some comments. 078fd78 Merged in raiden00/nuttx (pull request #669) Apps: - https://github.com/PX4-NuttX/apps/tree/px4-master_auto_rebase - PX4/NuttX-apps@444ee16 Changes from PX4-NuttX/apps (PX4/NuttX-apps@36806ba) in current PX4/master (dec0387) PX4/NuttX-apps@36806ba...444ee16 444ee16 (HEAD -> px4-master_auto_rebase, origin/px4-master_auto_rebase) [REJECTED] add-var-expansion-in-nsh-parse.patch e66470d (origin/master) Merged in raiden00/apps (pull request #143) db77b1e apps/examples/tcpblaster: Fix an error in time calculation. 19b8a52 apps/examples/tcpblaster/tcpblaster_server.c: Start time was not being initialized on the server side on the first pass through loop so the first output record had a crazy time. 749eccb Squashed commit of the following: 4d8b8fa apps/netutils/dhcpc: Activates BINDTODEVICE if available, and break up some long lines 0abe341 Merged in raiden00/apps (pull request #142) 3403b1b apps/nshlib/README.txt: Clarify arguments to the mkrd command. abcb66c Remove apps/interpreters/micropthon. There are several reasons for this. (1) the current version 1.3.8 is very old and no one is supporting it. (2) the port only includes the core micropython logic and none of the Python libraries. As such it is useless in any real application. (3) There have recently been compile failures reported. It looks like this is due to changes in newlib based toolchains that now bring in incompatible newlib header files. See issue 104 at https://bitbucket.org/nuttx/nuttx/issues/104/build-micropython-138-error. With no one dedicated to the support of micropython, it can no longer be carried in the NuttX apps/ repository. 36d6348 apps/nslib: Try to eliminate and uninitialized variable warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added missing desriptions for L1 control parameters.