Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup remaining sensor driver ioctl usage #14568

Merged
merged 6 commits into from
Apr 16, 2020
Merged

cleanup remaining sensor driver ioctl usage #14568

merged 6 commits into from
Apr 16, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Apr 2, 2020

The lps22hb barometer and sf1xx distance_sensor are the last sensor drivers using ioctl() and read().

Notably this PR removes the SENSORIOCSPOLLRATE and SENSORIOCRESET that were once used in nearly every driver.

I've also done a bit of cleanup in the Bosch bma180 and bmi160 drivers. The bma180 was also still using ioctl() and read(), but it was neither of these were in a functional state. We could probably delete them.

@TSC21
Copy link
Member

TSC21 commented Apr 4, 2020

Great stuff! @dagar are you still targeting 1.11 with this?

@TSC21 TSC21 requested a review from bkueng April 4, 2020 17:06
@dagar dagar force-pushed the pr-ioctl_cleanup branch from 3a64f5b to fe86891 Compare April 8, 2020 20:27
@dagar dagar merged commit 9ae2f0e into master Apr 16, 2020
@dagar dagar deleted the pr-ioctl_cleanup branch April 16, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants