Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove xlibsWrapper #194054

Closed
83 tasks done
trofi opened this issue Oct 2, 2022 · 1 comment
Closed
83 tasks done

Deprecate and remove xlibsWrapper #194054

trofi opened this issue Oct 2, 2022 · 1 comment
Labels
0.kind: bug

Comments

@trofi
Copy link
Contributor

trofi commented Oct 2, 2022 •
edited by SuperSandro2000
Loading

In #194044 I noticed unusual behaviour of xlibsWrapper when xorg is overridden. That PR handles override part.

But I think xlibsWrapper should just disappear. Where should be no reason (for example) for pulseaudio to depend on freetype at build time. xlibsWrapper is just the wrapper around a few libraries. Quoting pkgs/top-level/all-packages.nix:

  # Avoid using this. It isn't really a wrapper anymore, but we keep the name.
  xlibsWrapper = callPackage ../development/libraries/xlibs-wrapper {
    packages = [
      freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
      xorg.libXft xorg.libXext xorg.libSM xorg.libICE
    ];
  };

Mechanically we can replace xlibsWrapper with the list of packages it provides. Even better would be to audit needed libraries for each user and use only a subset of them.

Example fix:

More packages to fix:

Fixed packages:
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/1

@arcuru arcuru mentioned this issue Oct 4, 2022
Merged
13 tasks
@ghost ghost mentioned this issue Oct 6, 2022
Merged
9 tasks
LeSuisse added a commit to LeSuisse/nixpkgs that referenced this issue Oct 29, 2022
@LeSuisse
vlc: use xorg.libSM packages directly instead of xlibsWrapper indirec…
8fa4c2d 
…tion

See NixOS#194054
@LeSuisse LeSuisse mentioned this issue Oct 29, 2022
Merged
13 tasks
This was referenced Dec 6, 2022
Closed
Closed
@trofi trofi mentioned this issue Dec 17, 2022
Merged
@trofi trofi mentioned this issue Dec 27, 2022
Merged
13 tasks
@figsoda figsoda mentioned this issue Dec 28, 2022
Closed
SuperSandro2000 added a commit that referenced this issue Dec 29, 2022
@SuperSandro2000
Merge pull request #207938 from trofi/xlibsWrapper-removal
f104523 
Closes #194054
bors bot pushed a commit to bevyengine/bevy that referenced this issue Dec 29, 2022
@figsoda
improve nix docs (#7044)
d296326 
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
simonkampe pushed a commit to simonkampe/poetry2nix that referenced this issue Jan 4, 2023
@trofi @simonkampe
overrides: drop unused pkgs.xlibsWrapper package
bf3bc7b 
`xlibsWrapper` was a transitional package to move from monolithic
xorg package to modules. `nixpkgs` `python3Packages.pycairo` already
removed `pkgs.xlibsWrapper`. This change follow the same change.

Bug: NixOS/nixpkgs#194054
Closes: nix-community#863
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@figsoda @alradish
improve nix docs (bevyengine#7044)
26e2776 
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@figsoda @ItsDoot
improve nix docs (bevyengine#7044)
29202d9 
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
@cvengler cvengler mentioned this issue Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trofi @nixos-discourse