Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk2: drop unused xlibsWrapper import #207999

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Dec 27, 2022

On linux it's not used at all. On darwin removal of the dependency does not change generated binaries. Should be a no-op as well.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

On linux it's not used at all. On darwin removal of the dependency does
not change generated binaries. Should be a no-op as well.
@trofi trofi mentioned this pull request Dec 27, 2022
83 tasks
@ofborg ofborg bot requested review from 7c6f434c and lovek323 December 27, 2022 19:20
@SuperSandro2000 SuperSandro2000 merged commit 3c92463 into NixOS:master Dec 28, 2022
@trofi trofi deleted the gtk2-without-xlibsWrapper branch December 28, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants