-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages.X11Protocol: drop unused pkgs.xlibsWrapper build input #194184
Merged
trofi
merged 1 commit into
NixOS:master
from
trofi:perlPackages.X11Protocol-without-xlibsWrapper
Oct 8, 2022
Merged
perlPackages.X11Protocol: drop unused pkgs.xlibsWrapper build input #194184
trofi
merged 1 commit into
NixOS:master
from
trofi:perlPackages.X11Protocol-without-xlibsWrapper
Oct 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`perlPackages.X11Protocol` seems to define serialization format over the UNIX (or TCP) socket. It does not rely on on any X11 libraries and does not install ELF executables. Tested the change with diffoscope: the change is a no-on for both "out" and "devdoc" outputs.
83 tasks
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/1 |
Result of 13 packages marked as broken and skipped:
1 package blacklisted:
38 packages failed to build:
342 packages built:
|
None of the failures look related. All are pre-existing failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perlPackages.X11Protocol
seems to define serialization format over the UNIX (or TCP) socket. It does not rely on on any X11 libraries and does not install ELF executables.Tested the change with diffoscope: the change is a no-on for both "out" and "devdoc" outputs.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes