Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.X11Protocol: drop unused pkgs.xlibsWrapper build input #194184

Merged

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 3, 2022

perlPackages.X11Protocol seems to define serialization format over the UNIX (or TCP) socket. It does not rely on on any X11 libraries and does not install ELF executables.

Tested the change with diffoscope: the change is a no-on for both "out" and "devdoc" outputs.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

`perlPackages.X11Protocol` seems to define serialization format over the
UNIX (or TCP) socket. It does not rely on on any X11 libraries and does
not install ELF executables.

Tested the change with diffoscope: the change is a no-on for both
"out" and "devdoc" outputs.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/1

@trofi
Copy link
Contributor Author

trofi commented Oct 4, 2022

Result of nixpkgs-review pr 194184 run on x86_64-linux 1

13 packages marked as broken and skipped:
  • apple-music-electron
  • cwltool
  • gnome.gnome-documents
  • itch
  • python310Packages.mapbox
  • python310Packages.optuna
  • python310Packages.schema-salad
  • python310Packages.xgboost
  • python39Packages.mapbox
  • python39Packages.optuna
  • python39Packages.schema-salad
  • timedoctor
  • yandex-browser
1 package blacklisted:
  • appimage-run-tests
38 packages failed to build:
  • apache-airflow (python310Packages.apache-airflow)
  • faustStk
  • feishu
  • hipchat
  • irpf
  • magnetophonDSP.ConstantDetuneChorus
  • playonlinux
  • python310Packages.cairo-lang
  • python310Packages.elegy
  • python310Packages.functorch
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-terra
  • python310Packages.scikit-bio
  • python39Packages.apache-airflow
  • python39Packages.cairo-lang
  • python39Packages.elegy
  • python39Packages.functorch
  • python39Packages.qiskit
  • python39Packages.qiskit-aer
  • python39Packages.qiskit-finance
  • python39Packages.qiskit-ibmq-provider
  • python39Packages.qiskit-ignis
  • python39Packages.qiskit-machine-learning
  • python39Packages.qiskit-nature
  • python39Packages.qiskit-optimization
  • python39Packages.qiskit-terra
  • python39Packages.scikit-bio
  • spring
  • springLobby
  • streamdeck-ui
  • tebreak
342 packages built:
  • CuboCore.coretoppings
  • Sylk
  • _1password-gui
  • _1password-gui-beta
  • adapta-gtk-theme
  • alacritty
  • altair
  • anarchism
  • anup
  • anytype
  • appgate-sdp
  • appimage-run
  • arc-theme
  • armcord
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • avrdudess
  • aws-sso-cli
  • aws-vault
  • ayu-theme-gtk
  • beekeeper-studio
  • beets (beetsPackages.beets ,beetsPackages.beets-stable)
  • beets-unstable (beetsPackages.beets-unstable)
  • betterdiscord-installer
  • binaryen
  • bitwig-studio (bitwig-studio4)
  • bitwig-studio1
  • bitwig-studio2
  • bitwig-studio3
  • bloomrpc
  • bluejeans-gui
  • blueman
  • bootstrap-studio
  • bottles
  • brave
  • buttercup-desktop
  • calibre
  • capitaine-cursors
  • caprine-bin
  • ceph (ceph-dev)
  • ceph-client
  • ceph-csi
  • chromium
  • chrysalis
  • cider
  • cinnamon.cinnamon-screensaver
  • cinnamon.iso-flags-png-320x420
  • cinnamon.iso-flags-svg
  • clevis
  • cmake-language-server
  • commitizen
  • cozy-drive
  • cqrlog
  • crypto-org-wallet
  • davinci-resolve
  • dblatexFull
  • devdocs-desktop
  • disorderfs
  • dropbox
  • dropbox-cli
  • electron-mail
  • electronplayer
  • emojione
  • emscripten
  • enigma
  • eureka-editor
  • far2l
  • fast-cli
  • faust (faust2)
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2firefox
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustPhysicalModeling
  • faustlive
  • fff
  • filezilla
  • fim
  • firefly-desktop
  • flexget
  • flexoptix-app
  • framesh
  • fspy
  • genymotion
  • git-open
  • gnomeExtensions.taskwhisperer
  • google-chrome
  • google-chrome-beta
  • google-chrome-dev
  • grapejuice
  • gtk-pipe-viewer
  • guitarix
  • hackneyed
  • heroic
  • home-assistant-component-tests.airnow
  • home-assistant-component-tests.eafm
  • home-assistant-component-tests.profiler
  • home-assistant-component-tests.roomba
  • home-assistant-component-tests.sonos
  • home-assistant-component-tests.volvooncall
  • inkscape
  • inkscape-extensions.applytransforms
  • inkscape-with-extensions
  • irccloud
  • iso-flags
  • jabref
  • joplin-desktop
  • k40-whisperer
  • kabeljau
  • rep (kakounePlugins.rep)
  • kapitonov-plugins-pack
  • keeweb
  • kodiPackages.steam-launcher
  • lab
  • lbry
  • ldtk
  • ledger-live-desktop
  • lens
  • libceph
  • losslesscut-bin
  • luksmeta
  • lunar-client
  • lutris
  • lutris-free
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.VoiceOfFaust
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mangohud
  • marktext
  • mate.caja-dropbox
  • mate.mate-utils
  • mathpix-snipping-tool
  • minigalaxy
  • mkvtoolnix
  • mkvtoolnix-cli
  • mnemosyne
  • mobilecoin-wallet
  • mojave-gtk-theme
  • molotov
  • mooSpace
  • mpris-scrobbler
  • mpvScripts.convert
  • mycrypto
  • mytetra
  • napalm
  • neo4j-desktop
  • nestopia
  • nextcloud-client
  • notable
  • notion-app-enhanced
  • nuclear
  • numix-cursor-theme
  • numix-solarized-gtk-theme
  • nwg-drawer
  • octant-desktop
  • offpunk
  • open-music-kontrollers.mephisto
  • p3x-onenote
  • passky-desktop
  • pdm
  • perl534Packages.AppClusterSSH
  • perl534Packages.X11Protocol
  • perl534Packages.X11ProtocolOther
  • perl536Packages.AppClusterSSH
  • perl536Packages.X11Protocol
  • perl536Packages.X11ProtocolOther
  • pip-audit
  • plata-theme
  • plexamp
  • poetry2conda (python310Packages.poetry2conda)
  • pop-gtk-theme
  • protontricks
  • protonvpn-cli
  • protonvpn-gui
  • ptask
  • puppeteer-cli
  • python310Packages.aioeafm
  • python310Packages.amqtt
  • python310Packages.aria2p
  • python310Packages.bugwarrior
  • python310Packages.cachecontrol
  • python310Packages.catboost
  • python310Packages.cherrypy
  • python310Packages.consonance
  • python310Packages.diagrams
  • python310Packages.dissononce
  • python310Packages.expecttest
  • python310Packages.filecheck
  • python310Packages.graphviz
  • python310Packages.hypothesis-auto
  • python310Packages.inkex
  • python310Packages.jedi-language-server
  • python310Packages.junos-eznc
  • python310Packages.mxnet
  • python310Packages.napalm
  • python310Packages.napalm-hp-procurve
  • python310Packages.objgraph
  • python310Packages.pipdeptree
  • python310Packages.pipenv-poetry-migrate
  • python310Packages.poetry
  • python310Packages.protonvpn-nm-lib
  • python310Packages.pyairnow
  • python310Packages.pyalgotrade
  • python310Packages.pylxd
  • python310Packages.pytm
  • python310Packages.retworkx
  • python310Packages.roombapy
  • python310Packages.skidl
  • python310Packages.soco
  • python310Packages.strawberry-graphql
  • python310Packages.streamz
  • python310Packages.tasklib
  • python310Packages.taskw
  • python310Packages.transitions
  • python310Packages.volvooncall
  • python310Packages.ws4py
  • python310Packages.yowsup
  • python39Packages.aioeafm
  • python39Packages.amqtt
  • python39Packages.aria2p
  • python39Packages.bugwarrior
  • python39Packages.cachecontrol
  • python39Packages.catboost
  • python39Packages.cherrypy
  • python39Packages.consonance
  • python39Packages.diagrams
  • python39Packages.dissononce
  • python39Packages.expecttest
  • python39Packages.filecheck
  • python39Packages.graphviz
  • python39Packages.hypothesis-auto
  • python39Packages.inkex
  • python39Packages.jedi-language-server
  • python39Packages.junos-eznc
  • python39Packages.mxnet
  • python39Packages.napalm
  • python39Packages.napalm-hp-procurve
  • python39Packages.objgraph
  • python39Packages.papis
  • python39Packages.pipdeptree
  • python39Packages.pipenv-poetry-migrate
  • python39Packages.poetry
  • python39Packages.poetry2conda
  • python39Packages.protonvpn-nm-lib
  • python39Packages.pyairnow
  • python39Packages.pyalgotrade
  • python39Packages.pylxd
  • python39Packages.pytm
  • python39Packages.retworkx
  • python39Packages.roombapy
  • python39Packages.skidl
  • python39Packages.soco
  • python39Packages.strawberry-graphql
  • python39Packages.streamz
  • python39Packages.tasklib
  • python39Packages.taskw
  • python39Packages.transitions
  • python39Packages.volvooncall
  • python39Packages.ws4py
  • python39Packages.xgboost
  • python39Packages.yowsup
  • qdirstat
  • qemu_full
  • quark-engine
  • quodlibet-full
  • quodlibet-xine-full
  • rabbitvcs
  • radicle-upstream
  • rambox-pro
  • raven-reader
  • reaper
  • remnote
  • reveal-md
  • sabnzbd
  • saleae-logic-2
  • sambaFull (samba4Full)
  • session-desktop
  • sharedown
  • shutter
  • signal-desktop
  • slack
  • slimerjs
  • soco-cli
  • sonixd
  • sparkleshare
  • ssb-patchwork
  • standardnotes
  • station
  • steam
  • steam-rom-manager
  • steam-run
  • steam-tui
  • steamcmd
  • subtitleeditor
  • tambura
  • tang
  • tasknc
  • taskwarrior
  • tdesktop
  • teams
  • teamviewer
  • teleport
  • tidal-hifi
  • timeular
  • tinygo
  • trezor-suite
  • tribler
  • tusk
  • uhk-agent
  • uhk-udev-rules
  • ungoogled-chromium
  • unityhub
  • via
  • vial
  • vimPlugins.YouCompleteMe
  • vit
  • vscode-extensions.ms-python.python
  • wayst
  • wio
  • wootility
  • wpa_supplicant_gui
  • xdg-utils
  • xfce.catfish
  • xivlauncher
  • ycmd
  • ytmdesktop
  • zecwallet-lite
  • zettlr
  • zrythm
  • zulip

@trofi
Copy link
Contributor Author

trofi commented Oct 4, 2022

Result of nixpkgs-review pr 194184 run on x86_64-linux 1
38 packages failed to build:

None of the failures look related. All are pre-existing failures.

@trofi trofi merged commit e13d0f5 into NixOS:master Oct 8, 2022
@trofi trofi deleted the perlPackages.X11Protocol-without-xlibsWrapper branch October 8, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants