Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imhex: drop unused xlibsWrapper input #201606

Merged
merged 1 commit into from
Nov 18, 2022
Merged

imhex: drop unused xlibsWrapper input #201606

merged 1 commit into from
Nov 18, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 17, 2022 •
edited
Loading

Validated as no change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
imhex: drop unused xlibsWrapper input
bf7f28b 
Validated as no change in `out` output with diffoscope.
@trofi trofi mentioned this pull request Nov 17, 2022
Closed
83 tasks
@ofborg ofborg bot requested a review from Qubasa November 17, 2022 08:27
@trofi
Copy link
Contributor Author

trofi commented Nov 18, 2022

Result of nixpkgs-review pr 201606 run on x86_64-linux 1

1 package built:
  • imhex

@trofi trofi merged commit f7eadf7 into NixOS:master Nov 18, 2022
@trofi trofi deleted the imhex-without-xlibsWrapper branch November 18, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubasa Qubasa Awaiting requested review from Qubasa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trofi