Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify objects to change/refactor for OpenStudio 3 #3551

Closed
macumber opened this issue May 24, 2019 · 8 comments
Closed

Identify objects to change/refactor for OpenStudio 3 #3551

macumber opened this issue May 24, 2019 · 8 comments

Comments

@macumber
Copy link
Contributor

OpenStudio 3 will be an opportunity to remove or refactor any existing objects. Let's identify objects here and then create new tickets to do the work

@macumber
Copy link
Contributor Author

Move standards fields of OS:SpaceType and OS:Building to be AdditionalProperties?

Remove OS:StandardsInformation:Material and OS:StandardsInformation:Construction, replace with AdditionalProperties?

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 26, 2019


Enhancement requests that would require breaking API and should be considered for 3.0.0:

jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Sep 26, 2019
jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Nov 22, 2019
@jmarrec jmarrec added this to the OpenStudio 3.0.0 Official milestone Nov 25, 2019
@jmarrec
Copy link
Collaborator

jmarrec commented Dec 2, 2019

  • AFN cleanup #3525: AFN cleanup (which includes changed what the Ctors takes as argument, so breaking API)

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 27, 2020

  • WaterHeaterHeatPump should be renamed to WaterHeaterHeatPumpPumped like the E+ class. It's confusing. I aways have to check whether WaterHeaterHeatPumpPumped (no) and WaterHeaterHeatPumpWrapped (yes) are implemented to know which it is
    • Prior to E+ 8.4, there as only one class in E+: WaterHeater:HeatPump
  • WaterHeaterHeatPump(Pumped) availablity schedule shouldn't be optional but default to always On

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 29, 2020

  • Low temperature objects (ZoneHVACLowTempRadiantVarFlow, ZoneHVACLowTempRadiantConstFlow and ZoneHVACLowTemperatureElectric) should probably just default the Radiant Surface Type to "Ceilings" the Ctor and make radiantSurfaceType() return a non optional string instead of relying on IDD default anyways (at least the ZoneHVACLowTempRadiantVarFlow is already NOT providing isRadiantSurfaceDefaulted() but are providing resetRadiantSurfaceType() though).

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2020

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 13, 2020

  • AirLoopHVAC:UnitarySystem. Change name of field DOAS DX Cooling Coil Leaving Minimum Air Temperature to Minimum Supply Air Temperature to match E+
# OpenStudio.idd
  N2,  \field DOAS DX Cooling Coil Leaving Minimum Air Temperature
# EnergyPlus
  N2 , \field Minimum Supply Air Temperature
       \type real
       \units C
       \minimum 0.0
       \maximum 20.0
       \default 2.0
       \autosizable
       \note When Use DOAS DX Cooling Coil is specified as Yes, Minimum Supply Air Temperature
       \note defines the minimum DOAS DX cooling coil leaving air temperature that should
       \note be maintained to avoid frost formation. This field is not autosizable when
       \note the input for Use DOAS DX Cooling Coil = Yes.

@tijcolem
Copy link
Collaborator

tijcolem commented May 1, 2020

@jmarrec 3.0.0 has been released so I'd like to close this issue. If there is anything worth keeping in here can we open new issues for these? Otherwise, let's just close.

@jmarrec jmarrec closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants