Chiller:Electric:EIR API related to node need a serious refactor

[jmarrec]

None of these should exist, especially not in the public header (ChillerElectricEIR.hpp):

  bool setChilledWaterInletNodeName(std::string chilledWaterInletNodeName);
  bool setChilledWaterOutletNodeName(std::string chilledWaterOutletNodeName);

  bool setCondenserInletNodeName(boost::optional<std::string> condenserInletNodeName);
  bool setCondenserInletNodeName(std::string condenserInletNodeName);
  void resetCondenserInletNodeName();

  bool setCondenserOutletNodeName(boost::optional<std::string> condenserOutletNodeName);
  bool setCondenserOutletNodeName(std::string condenserOutletNodeName);
  void resetCondenserOutletNodeName();

  bool setHeatRecoveryInletNodeName(boost::optional<std::string> heatRecoveryInletNodeName);
  bool setHeatRecoveryInletNodeName(std::string heatRecoveryInletNodeName);
  void resetHeatRecoveryInletNodeName();

  bool setHeatRecoveryOutletNodeName(boost::optional<std::string> heatRecoveryOutletNodeName);
  bool setHeatRecoveryOutletNodeName(std::string heatRecoveryOutletNodeName);
  void resetHeatRecoveryOutletNodeName();

All of these plant loop connections are supposed to be set using addToNode / addToTertiaryNode.

ChillerElectricEIR::addToNode should probably be overloaded to do something like what I've done for CentralHeatPumpSystem:

OpenStudio/src/model/CentralHeatPumpSystem.cpp

Lines 194 to 221 in 5dc8c4e

	bool CentralHeatPumpSystem_Impl::addToNode(Node & node)
	{
	boost::optional<PlantLoop> t_plantLoop = node.plantLoop();
	// If trying to add to a node that is on the supply side of a plant loop
	if( t_plantLoop ) {
	if( t_plantLoop->supplyComponent(node.handle()) ) {
	// If there is already a cooling Plant Loop
	boost::optional<PlantLoop> coolingPlant = this->coolingPlantLoop();
	if (coolingPlant) {
	// And it's not the same as the node's loop
	if (t_plantLoop.get() != coolingPlant.get()) {
	// And if there is no heatingPlantLoop (tertiary)
	boost::optional<PlantLoop> heatingPlant = this->heatingPlantLoop();
	if (!heatingPlant) {
	// Then try to add it to the tertiary one
	LOG(Warn, "Calling addToTertiaryNode to connect it to the tertiary (=heating) loop for " << briefDescription());
	return this->addToTertiaryNode(node);
	}
	}
	}
	}
	}
	// All other cases, call the base class implementation
	return WaterToWaterComponent_Impl::addToNode(node);
	}

@eringold can give you a MCVE of a ruby script that produces a hard crash

[eringold]

m = OpenStudio::Model::Model.new

chiller = OpenStudio::Model::ChillerElectricEIR.new(m)

puts chiller

node = OpenStudio::Model::Node.new(m)

chiller.setHeatRecoveryInletNodeName(node.name.get)

puts chiller

chiller.setHeatRecoveryOutletNodeName(node.name.get)

puts chiller

The above will not hard crash, but will print:

[BOOST_ASSERT] <2> Assertion result failed on line 665 of bool __cdecl openstudio::model::detail::ChillerElectricEIR_Impl::setHeatRecoveryInletNodeName(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >) in file C:\Users\jenkins\git\OpenStudio\openstudiocore\src\model\ChillerElectricEIR.cpp.

and

[BOOST_ASSERT] <2> Assertion result failed on line 685 of bool __cdecl openstudio::model::detail::ChillerElectricEIR_Impl::setHeatRecoveryOutletNodeName(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >) in file C:\Users\jenkins\git\OpenStudio\openstudiocore\src\model\ChillerElectricEIR.cpp.

and otherwise do nothing to the chiller.

[jmarrec]

Related to the tertiary node: #3111, might be worth doing both objects at the same time.