Chiller:Electric:EIR node API refactor, ChillerAbsorption/ChillerAbsorption tertiary node refactor

[jmarrec]

Pull request overview

• Fixes Chiller:Electric:EIR API related to node need a serious refactor #3606: Refactor Chiller:Electric:EIR API related to node: no getter/setter to manipulate nodes by name.

• Fixes ChillerAbsorption is missing implementation of tertiary nodes for Generator Loop #3111: Add tertiary node for ChillerAbsoprtion

• For ChillerAbsoprtion, ChillerAbsoprtionIndirect, Chiller:Electric:EIR:

  • addToTertiaryNode overriden to only allow demand side
  • addToNode overriden to connect to tertiary loop if secondary (condenser Loop) is already connected, node to connect to is on the demand side of a different plant loop than the current condenser loop
  • For the Absorption chillers, connection to tertiary loop Switch Generator Heat Source Type to "HotWater", and back to "Steam" when disconnecting

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

@kbenne Still working on this one, realized model was missing methods, and FT was missing even more

[jmarrec]

@kbenne Ok, ready for review I think.

[kbenne]

@jmarrec did you or can you add one or more simulation tests to demonstrate this feature?

[jmarrec]

@kbenne NREL/OpenStudio-resources#97. A good idea to have done that, I realized I completely messed it up: all three chillers should have tertiary = DEMAND side of another loop, not supply:

• For ChillerAbsorption, ChillerAbsorptionIndirect: this is the generator loop (Hot water loop (or steam, but not in OS)), so it should logically be on the demand side of that one. No problem here.
• For ChillerElectricEIR, it's way trickier...
  • But given that the chiller isn't "active" in terms of responding to any loop on the HR loop, I think it makes more sense on the demand side
  • There are no example files with a ChillerElectricEIR with HR, but Chiller:EngineDriven, and that's on the demand side
  • It seems that I found a tiny sentence in the engineering reference guide after all that seem to indicate demand side... cf here

  • Note that the heat recovery side of the chiller is placed on the demand-side of a heat recovery loop which will typically supply a hot water storage tank.

  • But E+ will let your file run if you put it on the supply side of the Heat Recovery Loop...
  • So that seems akin to Clarify options for placement of solar collectors on PlantLoops: demand side? Supply side? Both EnergyPlus#7735 (Placement of solar collectors)
  • In the end until proven otherwise, I have chosen to limit connection to the DEMAND side of the Heat Recovery Loop