Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS:Site:WaterMainsTemperature missing choice CorrelationFromWeatherFile #3442

Closed
jmarrec opened this issue Mar 6, 2019 · 2 comments
Closed

OS:Site:WaterMainsTemperature missing choice CorrelationFromWeatherFile #3442

jmarrec opened this issue Mar 6, 2019 · 2 comments
Assignees
@jmarrec

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 6, 2019

Just a very simple IDD change. Was added in 9.0 (cf NREL/EnergyPlus#6771)
@jmarrec jmarrec self-assigned this Mar 6, 2019
@jmarrec jmarrec changed the title Site:WaterMainsTemperature missing choice CorrelationFromWeatherFile OS:Site:WaterMainsTemperature missing choice CorrelationFromWeatherFile Mar 6, 2019
@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 26, 2019

The Constructor defaults to "Schedule", while E+ now defaults to this new "CorrelationFromWeatherFile". Should be modified, perhaps for OS 3.0. cf #3551

jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Sep 26, 2019
@jmarrec
Fix NREL#3442 : The Ctor should default to this new field to match E+…
c8bffcb 
… but it would break historical behavior
@jmarrec jmarrec mentioned this issue Sep 26, 2019
Closed
jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Nov 22, 2019
@jmarrec
Fix NREL#3442 : The Ctor should default to this new field to match E+…
48f87bc 
… but it would break historical behavior
@jmarrec
Copy link
Collaborator Author

jmarrec commented Nov 25, 2019 •
edited
Loading

Closed in develop3 via c8bffcb

@jmarrec jmarrec closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jmarrec