-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mallets broken on master build #6464
Comments
Confirmed. |
Moderation: OT discussion deleted |
I can't replicate this issue and I'm not really a programmer by any stretch of the imagination but if you hand me the actual commit that caused it I can look into it. Also, please keep this discussion here. |
Oops, mb. Also, since all the builds i had the error were from the CI, i think this has something to do with the CI not bundling the stk. |
This issue is specific to windows. We rely on lmms/cmake/nsis/CMakeLists.txt Lines 76 to 80 in f39b3d5
However, the value is not set on the new MinGW toolchain files on master (by @lukas-w). MSVC builds don't work either, because MSVC isn't MinGW.
|
To elaborate a bit: #3227 (comment) |
I wrote an installation logic which should work in most cases(needs testing). # Install STK rawwaves
if(LMMS_HAVE_STK)
find_path(STK_RAWWAVE_ROOT
NAMES silence.raw sinewave.raw
HINTS "${STK_INCLUDE_DIR}/../.."
PATH_SUFFIXES share/stk/rawwaves share/libstk/rawwaves
)
if(STK_RAWWAVE_ROOT)
file(GLOB RAWWAVES "${STK_RAWWAVE_ROOT}/*.raw")
install(FILES ${RAWWAVES} DESTINATION "${DATA_DIR}/stk/rawwaves")
else()
message(WARNING "Can't find STK rawwave root!")
endif()
endif() |
This seems more like a |
The |
Clearly, but this is a "where is STK" problem, which doesn't really belong in installation logic, but rather dependency location. |
This comment was marked as outdated.
This comment was marked as outdated.
e.g.
I'd expect to use the bottom, not the top, no? |
My intention was to use |
Do we even have access to the top? What I'm trying to find is the bottom. |
Sorry, you're right... I'm confusing headers for source. 🤦♂️ |
Folder [data]/stk/rawaves is missing. Replace it and it works. Other findings:
In the newly created .xml file, the xml appears. |
Correct! This is a default folder which should not have to be user-inputted and is a native part of LMMS that should automatically set. |
|
Bug Summary
i tried using mallets on the latest master, only to find out it's broken.
Steps to reproduce
drop mallets on the song editor or the pattern editor and open instrument settings.
Expected behavior
mallets should play fine
Actual behavior
it gives the error 'stk not installed'. the instrument opens but doesn't give any sound.
Screenshot
https://youtu.be/hLBVz5jSoTM
Affected LMMS versions
1.3 master - builds #6462 and #6374 (pre merge ci build)
The text was updated successfully, but these errors were encountered: