Windows RC2 - Mallets won't load - Stk installation missing

[Umcaruje]

I got the same message on my linux computer, but fixed it by installing the stk package which was not installed. This is probably related to our build system.

[SirBothersome]

@Umcaruje what build? Windows 10 x64 loads just fine, running out of the box

[Umcaruje]

It won't load on windows 10 x64 rc2 for me. Weird. Maybe there is something leftover from the previous installation.

[tresf]

@SirBothersome please do a full uninstall before filing bugs. @Umcaruje this may be a bug with the windows packager. If the RAWWAVES aren't there, it throws this message.

Edit: Just realized you're on Linux for one post and Windows for another. Probably still a bug with your STK directory.

Generally when default directories are screwed up, it's because the user failed to uninstall the previous version. We really need to do a better cleanup job prior to a fresh install on all platforms. Removing %userprofile%/.lmmsrc.xml generally fixes these things.

If the RAWWAVES are missing, it's a bug with the Windows packager. If they're there, you need to get in the habit of uninstalling prior to reinstalling (and we should track all of these cleanup efforts for the various platforms).

Indirectly related #638, #2933, #1656, #1649 (comment)

[Umcaruje]

Actually, I just realised I didn't even have LMMS installed on this windows system, as I've recently reset it.

Aaand the stk folder is missing from the data folder in RC2:

It probably works for Leche because he has the rawwaves dir set to some older version. I just checked RC1 and it has the stk folder.

[tresf]

If the RAWWAVES are missing, it's a bug with the Windows packager.

It is. I'm not sure how this was ever working in 1.1 actually better yet the 1.2-rc1 build. There must have been a task to copy the .raw files to the install (../target AKA CMAKE_INSTALL_PREFIX) folder, but I can't find any evidence of it and it doesn't make any order of operation sense.

A better permanent home for this logic would be to write this into the plugins/stk/CMakeLists.txt file and handle Apple, Windows and Linux bundled installers in one fellow swoop.

Here's the fix for now.

-FILE(GLOB RAWWAVES "${CMAKE_INSTALL_PREFIX}/share/stk/rawwaves/*.raw")
-LIST(SORT RAWWAVES)
-INSTALL(FILES ${RAWWAVES} DESTINATION "${DATA_DIR}/stk/rawwaves")
+IF(LMMS_HAVE_STK)
+	FILE(GLOB RAWWAVES "${MINGW_PREFIX}/share/stk/rawwaves/*.raw")
+	LIST(SORT RAWWAVES)
+	INSTALL(FILES ${RAWWAVES} DESTINATION "${DATA_DIR}/stk/rawwaves")
+ENDIF()

[miketurn]

I apologize, but I am quite confused.
I am experiencing the same issue on Windows 7 (64Bit) with LMMS 1.2.0 RC2 (32Bit).
(I did a complete uninstall and I deleted the lmmsrc.xml)
From what I understand, this issue is closed because it has been fixed in the sense that it will be in a future release. Is there a way that it can be manually fixed, maybe by copying something from the 1.1.3 or 1.2.0 RC1?
Thank You

[tresf]

@miketurn a temporary workaround until RC3 is released is to install LMMS 1.2-RC1 and then install LMMS 1.2-RC2 over the top.

[Rossmaxx]

i experienced the same issue on the latest master and wrote an issue for it #6464. was searching for stk installation and found this closed issue instead.

[tresf]

i experienced the same issue on the latest master and wrote an issue for it #6464. was searching for stk installation and found this closed issue instead.

A long time ago, MINGW_PREFIX was the only way to know where files existed when targeting Windows. Fortunately, MSVC has improved upon this, but the old prefixes need to be updated to use either an MSVC conditional or a MINGW conditional.

In the case of STK, it has a formula ready on vcpkg, so I'd look there first, quoting the portfile.cmake from vcpkg:

file(GLOB RAWFILES ${SOURCE_PATH}/rawwaves/*.raw)
file(COPY ${RAWFILES} DESTINATION ${CURRENT_PACKAGES_DIR}/share/libstk/rawwaves)

@DomClark or @PhysSong should have experience with how MSVC environment prefixes. Otherwise, it will look something like this:

IF(LMMS_HAVE_STK) 
   IF(MSVC)
      # MSVC uses "share/libstk"
      FILE(GLOB RAWWAVES "${<<FIXME_CURRENT_PACKAGES_DIR>>}/share/libstk/rawwaves/*.raw") 
   ELSE()
      # MINGW uses "share/stk"
      FILE(GLOB RAWWAVES "${MINGW_PREFIX}/share/stk/rawwaves/*.raw") 
   ENDIF()
    
   LIST(SORT RAWWAVES) 
   INSTALL(FILES ${RAWWAVES} DESTINATION "${DATA_DIR}/stk/rawwaves") 
ENDIF() 

[anytizer]

Reference

Folder [data]/stk/rawaves is missing. Replace it and it works.

Other findings:

• Rename .lmmsrc.xml file.
• Close LMMS and reopen it.
• In the configuration window, you do NOT see options to enter stk path.

In the newly created .xml file, the xml appears.
<paths stkdir="data:/stk/rawwaves/"/>