Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autoscroll by default #6462

Closed
wants to merge 16 commits into from

Conversation

LostRobotMusic
Copy link
Contributor

Close this if I'm wrong, but I'm pretty sure most users would prefer to have this disabled by default.

(Like always, I have no idea what I'm doing, but this stack of commits should be fixed by the squash-and-merge option I assume)

@LmmsBot
Copy link

LmmsBot commented Jul 12, 2022

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Linux

macOS

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/1774e68a-af41-4858-be4c-16cabf9cc7e1/artifacts/0/lmms-1.3.0-alpha.1.231+g49b1f83e4-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17771?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/fd686fe6-6b25-46f6-956e-1f9dbe55a777/artifacts/0/lmms-1.3.0-alpha.1.231+g49b1f83e4-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17775?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/v4ghf0h41v041y15/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/44152129"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/qurocd8t0p2lux75/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/44152129"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/7f86a93b-4207-45ef-85ff-13d97ad75e83/artifacts/0/lmms-1.3.0-alpha.1.231+g49b1f83e4-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17773?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/756eecb2-b223-45d7-9be2-2498c2831229/artifacts/0/lmms-1.3.0-alpha.1.231+g49b1f83e4-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17772?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "e967ae18d53b27cac4dd66735fa5d3c3148e8851"}

@Monospace-V
Copy link
Contributor

Personally, I tend to prefer by-default auto-scroll on, because like seeing the part of the song that's playing, more often than seeing a different part. Is it intuitive to have auto-scroll off by default? The only people the defaults matter to, are the new users who don't want to mess with defaults too much. The old users change their workflow as they get more comfortable with using LMMS.
I'd like to request a poll, if one hasn't been done already.

@RiedleroD
Copy link
Contributor

RiedleroD commented Jul 19, 2022

autoscroll doesn't save to project files (or templates, for that matter), so I have to change it every time I open a project or create a new one.

edit: also there's no option to change the default by other means.

That's the real problem imo

@yohannd1
Copy link

Yeah, I think the best would be that it was a per-project option (and, since you can customize the default project template, a custom default for it could be set there)

@allejok96
Copy link
Contributor

Editing the default project template feels like a non-intuitive way to change a playback setting. If we just saved the state of the button when LMMS exits, would that be too much of a compromise? (Instead of saving it per-project)

@Spekular
Copy link
Member

I'm a big fan of the flexibility afforded by saving it per-project, personally. For production work I basically always want autoscroll off, but I have a few completed backing track projects where autoscroll is desireable (for playing along). A per-project setting accomodates that sort of thing very well.

@LostRobotMusic LostRobotMusic deleted the autoscroll-disable branch May 13, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants