Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STK rawwave installation in Windows builds #6705

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

PhysSong
Copy link
Member

@PhysSong PhysSong commented May 8, 2023

Fixes #6464.
This PR also makes the rawwave installation handled by CMake scripts on macOS.

@superpaik
Copy link
Contributor

Tested ok with both MSVC and MINGW builds installations

@PhysSong PhysSong requested a review from tresf May 28, 2023 02:34
Copy link
Member

@tresf tresf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOS, rawwaves exists, has the relevant .raw files, Mallets tested and working.

@tresf
Copy link
Member

tresf commented Jun 1, 2023

Fixes #6464. This PR also makes the rawwave installation handled by CMake scripts on macOS.

Curious, why not do the same for Linux?

# Copy rawwaves directory for stk/mallets
mkdir -p "${APPDIR}usr/share/stk/"
cp -R /usr/share/stk/rawwaves/ "${APPDIR}usr/share/stk/"

@PhysSong
Copy link
Member Author

PhysSong commented Jun 1, 2023

Curious, why not do the same for Linux?

Because LMMS uses system-wide installation of rawwaves when installed locally, and I didn't wanted to change that behavior. Please suggest me any ideas, if you have one.

@tresf
Copy link
Member

tresf commented Jun 1, 2023

Because LMMS uses system-wide installation of rawwaves when installed locally

I had forgotten about local installs.

Please suggest me any ideas, if you have one.

This is a good question. I suppose the installation would be copying over itself for local installs, however when using a custom install prefix, it would not be redundant.

I suppose it's justified to keep this task in the .AppImage script for now, however it may be beneficial as a long -term goal to accommodate this in CMake.

@PhysSong PhysSong merged commit 405738f into LMMS:master Jun 24, 2023
@PhysSong PhysSong deleted the stk-rawwave-path branch June 24, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mallets broken on master build
3 participants