-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix STK rawwave installation in Windows builds #6705
Conversation
Tested ok with both MSVC and MINGW builds installations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on MacOS, rawwaves
exists, has the relevant .raw
files, Mallets tested and working.
Curious, why not do the same for Linux? lmms/cmake/linux/package_linux.sh.in Lines 110 to 112 in b322f80
|
Because LMMS uses system-wide installation of rawwaves when installed locally, and I didn't wanted to change that behavior. Please suggest me any ideas, if you have one. |
I had forgotten about local installs.
This is a good question. I suppose the installation would be copying over itself for local installs, however when using a custom install prefix, it would not be redundant. I suppose it's justified to keep this task in the |
Fixes #6464.
This PR also makes the rawwave installation handled by CMake scripts on macOS.