Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Plugins and ingress.class #690

Closed
hbagdi opened this issue May 21, 2020 · 2 comments
Closed

Spike: Plugins and ingress.class #690

hbagdi opened this issue May 21, 2020 · 2 comments
Assignees
@hbagdi
Labels
area/spike breaking change
Milestone
0.10.0

Comments

@hbagdi
Copy link
Member

hbagdi commented May 21, 2020 •
edited
Loading

Users have run into issues with plugins when using a custom Ingress class.
If plugins don't have the ingress.class annotation, then updating them doesn't trigger an update of configuration in Kong.
Figure out the how should KongPlugin and KongClusterPlugin resources interact with ingress.class annotation and document the decision here, and create additional issues to do the work if needed.

The result of the spike can be found here: https://docs.google.com/document/d/1qMwurrFiOMoy2EK569y6qY-9cLGKJrkTfloqNyp_J6o/edit?usp=sharing
@hbagdi hbagdi self-assigned this May 21, 2020
@hbagdi hbagdi added this to the 0.10.0 milestone Jun 1, 2020
@hbagdi
Copy link
Member Author

hbagdi commented Jun 11, 2020

I expanded the scope of this issue and wrote up a document on how to fix this for all resources:
https://docs.google.com/document/d/1qMwurrFiOMoy2EK569y6qY-9cLGKJrkTfloqNyp_J6o/edit?usp=sharing

Comments/suggestions are welcome.

This was referenced Jun 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@hbagdi
Copy link
Member Author

hbagdi commented Jun 15, 2020

Closing this issue as the spike is complete and the issues to track implementation have been created.

@hbagdi hbagdi closed this as completed Jun 15, 2020
@hbagdi hbagdi mentioned this issue Jul 8, 2020
Closed
hbagdi pushed a commit that referenced this issue Aug 26, 2020
feat: rework handling of ingress.class annotation
de29e98 
Summary
- Introduces two new configuration options for classless KongConsumers and Ingress resources
- Changes ingress.class annotation requirements fro TCPIngress, Ingress (all versions), KongConsumers, Global KongClusterPlugins
- Removes Ingress.class annotation based filtering in ResourceEventHandler, this should fix bugs associated
  with updates not being propagated to Kong

This changeset is part of #690.
From #767
@hbagdi hbagdi mentioned this issue Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbagdi hbagdi

Labels
area/spike breaking change
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@hbagdi