Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore TCPIngress resource which do not contain a class #733

Closed
hbagdi opened this issue Jun 15, 2020 · 1 comment
Closed

ignore TCPIngress resource which do not contain a class #733

hbagdi opened this issue Jun 15, 2020 · 1 comment
Labels
area/feature New feature or request breaking change
Milestone
0.10.0

Comments

@hbagdi
Copy link
Member

hbagdi commented Jun 15, 2020

Users who run multiple kong ingress controllers in a cluster would like a way to control the TCPIngress resources that are owned by a controller. This part is already supported.

With other changes that are happening for #690, the following change is needed:
TCPIngress should be satisfied if the ingress class matches that configured in the controller.

Please do not that this behavior is not going to be configurable, meaning, there will be no way to allow for classless TCPInress resources to be picked up by the controller.

Please see the doc in #690 for more background.
@hbagdi hbagdi added area/feature New feature or request breaking change labels Jun 15, 2020
@hbagdi hbagdi added this to the 0.10.0 milestone Jun 15, 2020
@hbagdi hbagdi added the trello label Jun 15, 2020
@rainest rainest mentioned this issue Jul 8, 2020
Merged
@rainest
Copy link
Contributor

rainest commented Aug 26, 2020

Handled in #767.

@rainest rainest closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/feature New feature or request breaking change
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@rainest @hbagdi