Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure KongClusterPlugin configured as global plugins have the ingress.class annotation #734

Closed
hbagdi opened this issue Jun 15, 2020 · 2 comments
Labels
area/feature New feature or request breaking change
Milestone

Comments

@hbagdi
Copy link
Member

hbagdi commented Jun 15, 2020

KongClusterPlugin can be configured as global plugins using the label global: "true".
KongPlugin can do the same, but that behavior is set to be removed with #681.

Change the store abstraction to only return global plugins if they have a matching ingress.class annotation on them.
This is required to avoid multiple Kong Ingress Controllers from picking global plugins. Users wish to configure different set of global plugins for internal and external ingress controllers.

For more details on background, please see doc in #690.

@rainest
Copy link
Contributor

rainest commented Aug 26, 2020

Handled in #767.

@rainest rainest closed this as completed Aug 26, 2020
@zffocussss
Copy link

what if we have two kong ingress controllers, such as KONG-A and KONG-B.but I want to use a same kongclusterplugin (same plugin code and same plugin conf) in both of the kong ingress controllers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request breaking change
Projects
None yet
Development

No branches or pull requests

3 participants