Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global plugins should be possible only via KongClusterPlugins and not KongPlugins #681

Closed
hbagdi opened this issue May 21, 2020 · 1 comment
Closed

Global plugins should be possible only via KongClusterPlugins and not KongPlugins #681

hbagdi opened this issue May 21, 2020 · 1 comment
Labels
area/feature New feature or request breaking change
Milestone
0.10.0

Comments

@hbagdi
Copy link
Member

hbagdi commented May 21, 2020

Two years ago when we started with the project, KongPlugin resource was introduced. Over time, various features have been added on top of it, one of them being global plugins using a label of global: "true". However, this breaks the Kubernetes RBAC model because global plugins impact traffic that is flowing across all namespaces. This should be possible using KongClusterPlugin only.
@hbagdi hbagdi added this to the 0.10.0 milestone May 21, 2020
@hbagdi hbagdi mentioned this issue Jun 15, 2020
Closed
rainest pushed a commit that referenced this issue Jun 29, 2020
feat: remove support for global KongPlugins
0e62239 
Fix #681
@rainest rainest mentioned this issue Jun 29, 2020
Merged
hbagdi pushed a commit that referenced this issue Jul 8, 2020
feat: drop support for global-level KongPlugins resources
682c383 
Breaking change

This commit drops support for configuring "global" plugins in Kong using the namespaced KongPlugin resources.
Instead, only KongClusterPlugin should be used for configuring "global" plugins in Kong.

Fix #681
@rainest
Copy link
Contributor

rainest commented Aug 28, 2020

Done per #751

@rainest rainest closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/feature New feature or request breaking change
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@rainest @hbagdi