Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: accept change to KongPlugin which do not have an ingress.class annotation #735

Closed
hbagdi opened this issue Jun 15, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@hbagdi
Copy link
Member

hbagdi commented Jun 15, 2020

Current behavior

If a KongPlugin is created, updated or deleted, the resource handler for the corresponding informer in the code drops the events if the plugin didn't have the ingress.class annotation on it.
This leads to an undocumented assumption that KongPlugin resources should be ingress.class aware, which is unintended and hence this is a bug.

Desired behavior

Change the informer code to make sure such events are not dropped.
KongPlugin should not be ingress class aware, except in case of a global plugin (#734).
A class annotation being present on KongPlugin resource should make no difference.

For more details on background, please see doc in #690.

@rainest
Copy link
Contributor

rainest commented Aug 26, 2020

Handled in #767 by removing ResourceEventHandler filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants