Use client as primary token source #1967
Conversation
validate against entering a duplicate addressThis comment was generated by todo based on a
|
chmanie
force-pushed
the
refactor/token-info
branch
from
74b5fcd to
2f02621
Compare
| console.warn(`Token with address ${tokenAddress} not found on server`); | ||
| } | ||
|
|
||
| const serverData: TokenInfo = serverDataResult |
There was a problem hiding this comment.
serverDataResult here returns:
{
tokenInfo: { ... }
}So this logic condition will always fail
| return ( | ||
| <div className={styles.main}> | ||
| <div className={styles.tokenChoice}> | ||
| <TokenIcon token={token} name={token.name || undefined} /> |
There was a problem hiding this comment.
There's an error with the HookedTokenIcon.
I think it passes down some props to the underlying svg, that it can't handle
There was a problem hiding this comment.
Yeah, I honestly have no idea what causes this. $$typeof comes from react so it should be OK
| @@ -190,17 +183,6 @@ const StepCreateToken = ({ | |||
| help={MSG.helpTokenSymbol} | |||
| /> | |||
| </div> | |||
| <div className={styles.inputFieldWrapper}> | |||
| <ActionFileUpload | |||
| name="tokenIcon" | |||
There was a problem hiding this comment.
If we removed the Token info from the native token creation screen, shouldn't we also remove it from the external token "creation" page?:
There was a problem hiding this comment.
Also, I think we need to make @JoinColony/product aware of this change
There was a problem hiding this comment.
Yes, we should remove that, good catch!
|
|
||
| let serverDataResult; | ||
| try { | ||
| const { data } = await client.query({ |
There was a problem hiding this comment.
This query always fails on my machine claiming it can't the iconHash prop on some undefined object:
There was a problem hiding this comment.
Thanks, this is a good find!
chmanie
force-pushed
the
refactor/token-info
branch
2 times, most recently
from
26694d0 to
3758e62
Compare
There was a problem hiding this comment.
After adding those two fixes everything seems to be working fine, so congrats Chris!
This was a lot of work, both on the dapp and the server side, and you've done an amazing job.
I've tested every interaction I could think of: native tokens, external tokens, send in, claiming, minting, etc.
Everything works well, but again, I do worry about the Ethplorer API key limitation.
I did find a UX issue we can improve on in the future:
- You send in an external token
- You claim it for your colony
- It won't show up in your colony's tokens, until you manually add it via it's address
This all works as expected now, but an improvement here would be to automatically add that token to the user's colony when claiming the funds, as we already have all the data we need for that.
But again, this is a minor improvement, and it's nowhere near a priority right now.
* Update colony tokens after mutation
chmanie
force-pushed
the
refactor/token-info
branch
from
3758e62 to
2003676
Compare
Description
This PR adds local resolvers for token data which query the token contracts directly instead of relying on the server. The colony and user tokens are still stored on the server but just as addresses. Furthermore we changed the way the tokens are added to colonies and users (via entering a token address in the edit tokens dialog).
New stuff ✨
Changes 🏗
Resolves #1959
Resolves #1971
Resolves #1978