Refactor token dialogs #1968
Merged
Refactor token dialogs #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate against entering a duplicate addressThis comment was generated by todo based on a
|
ceolson01
force-pushed
the
refactor/token-info-dialogs
branch
from
2ebf952 to
f6d656a
Compare
chmanie
reviewed
Jan 19, 2020
| variables: { address: colonyAddress }, | ||
| }); | ||
|
|
||
| const colonyTokens = (data && data.colony.tokens) || []; |
There was a problem hiding this comment.
This will change in #1967, be aware!
chmanie
reviewed
Jan 19, 2020
|
|
||
| const colonyTokens = (data && data.colony.tokens) || []; | ||
|
|
||
| const addToken = useCallback( |
There was a problem hiding this comment.
I actually thought the changes will only be applied if the user presses the submit button on the dialog. It seems they are applied directly which pretty much renders the cancel button nonsensical?
chmanie
reviewed
Jan 19, 2020
| const addToken = useCallback( | ||
| (newTokenAddress: Address) => { | ||
| const newAddresses = [ | ||
| ...colonyTokens.map(({ address }) => address), |
There was a problem hiding this comment.
This probably includes eth, so we might have to remove it again
chmanie
reviewed
Jan 19, 2020
| const allTokens = []; | ||
| const removeToken = useCallback( | ||
| (tokenAddressToRemove: Address) => { | ||
| const newAddresses = colonyTokens |
ceolson01
force-pushed
the
refactor/token-info-dialogs
branch
from
f6d656a to
65e6078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the token edit dialogs to abide by the new token logic.
New stuff ✨
TokenItemcomponentChanges 🏗
dangerLinktheme forButtonDeletions ⚰️
TokenCheckboxcomponentScreenshot 📷