Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAI and other external tokens are not displayed in the dapp #1978

Closed
auryn-macmillan opened this issue Jan 20, 2020 · 3 comments · Fixed by #1967
Closed

DAI and other external tokens are not displayed in the dapp #1978

auryn-macmillan opened this issue Jan 20, 2020 · 3 comments · Fixed by #1967
Assignees
Labels
bug P3 Medium - Low, Nice to Have
Milestone

Comments

@auryn-macmillan
Copy link

Steps to reproduce

  1. Send an external token (one that was not created by a colony) to a colony

Expected behaviour

A transaction with the token should show up in the transaction feed. Once it has been claimed, the token should show up in the colony's balance.

Actual behaviour

DAI and other external tokens are not displayed in the dapp at all. They can't be claimed in incoming transactions and and existing balances are not displayed.

My guess is that this is also related to #1967.

@rdig rdig self-assigned this Jan 22, 2020
@rdig rdig added this to the Sprint 42 milestone Jan 22, 2020
@rdig rdig assigned chmanie and unassigned rdig Jan 22, 2020
@rdig
Copy link
Member

rdig commented Jan 22, 2020

So this issue indeed exists, and I could successfully replicate it locally:

Screenshot from 2020-01-22 19-29-18

This will be solved by both #1967 and JoinColony/colonyServer#34 once they are deployed.

The issue arises when the specific token does not have an entry which the Dapp can pull information from.

As a quick patch until the above mentioned issues are fixed, I've manually added an entry with the DAI token, so your transaction will show up and you'll be able to claim it.

Screenshot from 2020-01-22 19-36-40

@rdig rdig added the P3 Medium - Low, Nice to Have label Jan 22, 2020
@auryn-macmillan
Copy link
Author

I still don't see incoming transactions in DAI for some reason, even though I can now see DAI balances in the colony.

Also, I noticed that there ETH now shows up twice, both in the Burn Signal colony and the screenshot you posted above.

@rdig
Copy link
Member

rdig commented Jan 23, 2020

Also, I noticed that there ETH now shows up twice, both in the Burn Signal colony and the screenshot you posted above.

This is a separate issue that will be as well resolved when we refactor the way token logic works in #1967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P3 Medium - Low, Nice to Have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants