Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYOT Display proper Token preview values #1976

Closed
wants to merge 1 commit into from
Closed

BYOT Display proper Token preview values #1976

wants to merge 1 commit into from

Conversation

rdig
Copy link
Member

@rdig rdig commented Jan 20, 2020

Description

This PR fixes a small issue with the "user external" create colony wizard path, where the Token's preview values would not be displayed.

This was due to the fact that the return object changed after refactoring the metadata storage, so this needed to be adjusted as well.

Changes

  • TokenSelector use the proper object for diplay Token details

Demo

Screenshot from 2020-01-20 17-00-10

Resolves #1971

@rdig rdig requested review from chmanie and ceolson01 January 20, 2020 15:04
@rdig rdig self-assigned this Jan 20, 2020
@rdig
Copy link
Member Author

rdig commented Jan 20, 2020

Closing this in favor of @chmanie 's #1967 which apparently already fixed this

@rdig rdig closed this Jan 20, 2020
@rdig rdig deleted the fix/1971-byot-doesnt-display-symbol-name branch March 23, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmanie chmanie Awaiting requested review from chmanie

@ceolson01 ceolson01 Awaiting requested review from ceolson01

Assignees

@rdig rdig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token name and symbol aren't displayed properly when creating a new colony
1 participant
@rdig