Pose Generation Update #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colin-lewis-19 can you review the changes to your pose generators and the observation creation functions? |
|
This looks good to me |
rct_optimizations/test/include/rct_optimizations_tests/observation_creator.h
Show resolved
Hide resolved
|
This also looks good to me. |
marip8
force-pushed
the
update/pose_generation
branch
from
fca2abe
to
669bd50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions for generating observation sets using the pose generators from #43. In order to make the pose generators easier to use with the observation generators, their structure was refactored into and interface with implementations.
The hand-eye unit tests currently only use one of the pose generators. We probably want to devise a way of testing all of the pose generators with the optimizations. I am still trying to figure out a clean way to do this but haven't come across a good solution yet.
Builds on #48