Update/pose generation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marip8 Could you give this a look? |
marip8
requested changes
May 19, 2020
There was a problem hiding this comment.
Looks pretty good overall. Good to see the unit tests work with all the methods.
We'll eventually update the unit tests and add observation generation functions that leverage these functions, so this will probably change a bit soon. We may also move the pose generation functions out of the test directory later so other packages can use them.
rct_optimizations/test/include/rct_optimizations_tests/pose_generator.h
Outdated
Show resolved
Hide resolved
rct_optimizations/test/include/rct_optimizations_tests/pose_generator.h
Outdated
Show resolved
Hide resolved
rct_optimizations/test/include/rct_optimizations_tests/pose_generator.h
Outdated
Show resolved
Hide resolved
schornakj
reviewed
May 19, 2020
marip8
requested changes
May 20, 2020
marip8
approved these changes
May 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utiility functions for generating camera poses relative to a target