Remove obsolete extrinsic hand eye optimizations #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@schornakj any thoughts about the removal of these old optimizations? |
|
@marip8 The changes you made to the example problems (in particular the fact that you only had to change a handful of type names) demonstrate that this is functionally a drop-in replacement, so I'm OK with officially replacing the two old optimization types with the new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the obsolete hand eye optimizations (extrinsic static camera/moving target, extrinsic 2D camera/static target, extrinsic 3D camera/static target) with the single new hand-eye optimization implementation from #38