Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase 1] Basic Form Controls #459

Merged
merged 26 commits into from
Apr 3, 2019
Merged

[Phase 1] Basic Form Controls #459

merged 26 commits into from
Apr 3, 2019

Conversation

CITguy
Copy link
Contributor

@CITguy CITguy commented Feb 22, 2019

Updates for v0.16.0-rc.0

Ryan A. Johnson and others added 6 commits February 22, 2019 12:03
* Radios (component)
* <hx-radio> (element)
* <hx-select> (element)

merge w radios
* docs: Update forms in docs
  * Stop using `label > input`.
  * Use `input[id] ~ label[for]` to support incoming
    radios and checkboxes development.
  * Use future markup for checkboxes and radios.
* src: cleanup beta Form styles
  * prepare for upcoming development
Miscellaneous Updates to prepare for Checkboxes, Radios, and Dropdown Selects.
@CITguy CITguy added this to the v0.16 milestone Feb 22, 2019
@HelixUI
Copy link
Contributor

HelixUI commented Feb 22, 2019

Deploy preview for helix-ui ready!

Built with commit a574561

https://deploy-preview-459--helix-ui.netlify.com

Ryan A. Johnson and others added 18 commits February 25, 2019 17:35
[^459] fix(docs): correct modifications to docs assets
feat(HXElement): add 'hx-defined' attr on connect
* remove usage of `<hx-select></hx-select>`
  * except for Dropdown Select component (to be updated in separate PR)
* remove incorrect usage of `<hx-radio>`
* remove incorrect usage of `<hx-checkbox>`
[^459] docs(*): semi-revert demo config form refactor
* removed `[invalid]` styles
* add <hx-select-control>
  * [hx-changed] when 'change' happens on first <select> descendant
  * [hx-touched] when 'blur' happens on first <select> descendant
* <hx-select> and <select> styled invalid if:
  * hx-select-control[hx-changed] and select:invalid
  * hx-select-control[hx-touched] and select:invalid
  * hx-select-control.hxInvalid (forced styling by app author)
[^459] Dropdown Select (validation & behavior)
[^459] refactor(hx-checkbox): forms epic refactor hx-checkox and simplify
- handles adding 'hx-changed' and 'hx-touched' attrs to communicate state
…Element

feat(HXFormControLElement): centralize custom form control logic
chore(pr-review): corrections from pr review
Refactor element based css into component based css
refactor(fast-follow): css into components less fixes
@CITguy CITguy changed the title basic form controls [Phase 1] Basic Form Controls Apr 3, 2019
@CITguy CITguy marked this pull request as ready for review April 3, 2019 21:08
@CITguy CITguy merged commit 8db2144 into master Apr 3, 2019
@CITguy CITguy deleted the dev-basic-form-controls branch April 3, 2019 21:35
@CITguy CITguy added the :shipit: shipped label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants