-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phase 1] Basic Form Controls #459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Radios (component) * <hx-radio> (element) * <hx-select> (element) merge w radios
* docs: Update forms in docs * Stop using `label > input`. * Use `input[id] ~ label[for]` to support incoming radios and checkboxes development. * Use future markup for checkboxes and radios. * src: cleanup beta Form styles * prepare for upcoming development
Miscellaneous Updates to prepare for Checkboxes, Radios, and Dropdown Selects.
Deploy preview for helix-ui ready! Built with commit a574561 |
[^459] fix(docs): correct modifications to docs assets
feat(HXElement): add 'hx-defined' attr on connect
* remove usage of `<hx-select></hx-select>` * except for Dropdown Select component (to be updated in separate PR) * remove incorrect usage of `<hx-radio>` * remove incorrect usage of `<hx-checkbox>`
[^459] docs(*): semi-revert demo config form refactor
docs(*): refactor docs layouts
* removed `[invalid]` styles * add <hx-select-control> * [hx-changed] when 'change' happens on first <select> descendant * [hx-touched] when 'blur' happens on first <select> descendant * <hx-select> and <select> styled invalid if: * hx-select-control[hx-changed] and select:invalid * hx-select-control[hx-touched] and select:invalid * hx-select-control.hxInvalid (forced styling by app author)
[^459] Dropdown Select (validation & behavior)
[^459] refactor(hx-checkbox): forms epic refactor hx-checkox and simplify
- handles adding 'hx-changed' and 'hx-touched' attrs to communicate state
…Element feat(HXFormControLElement): centralize custom form control logic
chore(pr-review): corrections from pr review
Refactor element based css into component based css
refactor(fast-follow): css into components less fixes
[^459] feat(hx-radio-control): surf-584 phase I radio form control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for
v0.16.0-rc.0