Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[^459] Dropdown Select (phase 2) #462

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

CITguy
Copy link
Contributor

@CITguy CITguy commented Feb 25, 2019

JIRA: fast-follow to SURF-502

  • remove [invalid]
  • add <hx-select-control>
    • [hx-changed] when 'change' happens on first <select> descendant
    • [hx-touched] when 'blur' happens on first <select> descendant
  • <hx-select> and <select> styled invalid if:
    • hx-select-control[hx-changed] and select:invalid
    • hx-select-control[hx-touched] and select:invalid
    • hx-select-control.hxInvalid (forced styling by app author)

LGTM's

  • Dev LGTM
  • Design LGTM
  • Zoom LGTM

@HelixUI
Copy link
Contributor

HelixUI commented Feb 25, 2019

Deploy preview for helix-ui ready!

Built with commit 8e42b84

https://deploy-preview-462--helix-ui.netlify.com

@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch from 8fea781 to fc3906d Compare February 25, 2019 23:31
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev lgtm

@CITguy CITguy changed the title Dev bfc dropdown fast follow [^459] Dropdown Select (fast-follow) Feb 25, 2019
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoom LGTM

@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch from fc3906d to 09aef62 Compare February 26, 2019 17:42
@CITguy CITguy changed the base branch from dev-basic-form-controls to master February 26, 2019 20:27
@CITguy CITguy changed the base branch from master to dev-basic-form-controls February 26, 2019 20:28
@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch 2 times, most recently from 2c21222 to 37ac482 Compare March 8, 2019 01:24
@CITguy CITguy changed the title [^459] Dropdown Select (fast-follow) [^459] Dropdown Select (validation) Mar 8, 2019
@CITguy CITguy changed the title [^459] Dropdown Select (validation) [^459] Dropdown Select (validation & behavior) Mar 8, 2019
@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch 4 times, most recently from d1d361c to e39ffa8 Compare March 12, 2019 21:38
@CITguy CITguy requested review from 100stacks and catsiller March 13, 2019 00:32
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at 🏰 LGTM

@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch 2 times, most recently from 05476b0 to 45cc2cb Compare March 14, 2019 02:12
* removed `[invalid]` styles
* add <hx-select-control>
  * [hx-changed] when 'change' happens on first <select> descendant
  * [hx-touched] when 'blur' happens on first <select> descendant
* <hx-select> and <select> styled invalid if:
  * hx-select-control[hx-changed] and select:invalid
  * hx-select-control[hx-touched] and select:invalid
  * hx-select-control.hxInvalid (forced styling by app author)
@CITguy CITguy force-pushed the dev-bfc--dropdown-fast-follow branch from 45cc2cb to 8e42b84 Compare March 14, 2019 16:50
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev lgtm

@CITguy CITguy merged commit 99d2fe8 into dev-basic-form-controls Mar 14, 2019
@CITguy CITguy deleted the dev-bfc--dropdown-fast-follow branch March 14, 2019 17:13
@CITguy CITguy changed the title [^459] Dropdown Select (validation & behavior) [^459] Dropdown Select (phase 2) Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants