-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[^459] Dropdown Select (phase 2) #462
Conversation
Deploy preview for helix-ui ready! Built with commit 8e42b84 |
8fea781
to
fc3906d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zoom LGTM
fc3906d
to
09aef62
Compare
2c21222
to
37ac482
Compare
d1d361c
to
e39ffa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at 🏰 LGTM
05476b0
to
45cc2cb
Compare
* removed `[invalid]` styles * add <hx-select-control> * [hx-changed] when 'change' happens on first <select> descendant * [hx-touched] when 'blur' happens on first <select> descendant * <hx-select> and <select> styled invalid if: * hx-select-control[hx-changed] and select:invalid * hx-select-control[hx-touched] and select:invalid * hx-select-control.hxInvalid (forced styling by app author)
45cc2cb
to
8e42b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev lgtm
JIRA: fast-follow to SURF-502
[invalid]
<hx-select-control>
[hx-changed]
when 'change' happens on first<select>
descendant[hx-touched]
when 'blur' happens on first<select>
descendant<hx-select>
and<select>
styled invalid if:hx-select-control[hx-changed]
andselect:invalid
hx-select-control[hx-touched]
andselect:invalid
hx-select-control.hxInvalid
(forced styling by app author)LGTM's