refactor(HXCheckboxElement): remove need for htmlFor attr/prop

HelixDesignSystem · Feb 25, 2019 · fc3906d · fc3906d
1 parent f9de838
commit fc3906d
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/src/helix-ui/elements/HXCheckboxElement.js b/src/helix-ui/elements/HXCheckboxElement.js
@@ -2,6 +2,8 @@ import { HXElement } from './HXElement';
 import shadowMarkup from './HXCheckboxElement.html';
 import shadowStyles from './HXCheckboxElement.less';
 
+// TODO: add change/input listener to add '.hx-dirty' class to component wrapper (.hxCheckbox)
+
 /**
  * Defines behavior for the `<hx-checkbox>` element.
  *
@@ -34,19 +36,7 @@ export class HXCheckboxElement extends HXElement {
      * @type {HTMLElement}
      */
     get controlElement () {
-        return this.getRootNode().querySelector(`[id="${this.htmlFor}"]`);
-    }
-
-    /**
-     * ID of associated checkbox control.
-     *
-     * @type {string}
-     */
-    get htmlFor () {
-        return this.getAttribute('for') || '';
-    }
-    set htmlFor (value) {
-        this.setAttribute('for', value);
+        return this.parentNode.querySelector('input[type="checkbox"]');
     }
 
     /** @private */