Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Updates to prepare for Checkboxes, Radios, and Dropdown Selects. #458

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Miscellaneous Updates to prepare for Checkboxes, Radios, and Dropdown Selects. #458

merged 5 commits into from
Feb 22, 2019

Conversation

CITguy
Copy link
Contributor

@CITguy CITguy commented Feb 22, 2019 •
edited
Loading

  • Dev LGTM
  • Dev LGTM

@HelixUI
Copy link
Contributor

HelixUI commented Feb 22, 2019 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 5e19f1a

https://deploy-preview-458--helix-ui.netlify.com

CITguy
CITguy commented Feb 22, 2019
View reviewed changes
src/helix-ui/styles/components/text-inputs.less
@@ -10,7 +10,7 @@
display: block;
font-size: 1rem; // 16px
height: 2rem;
padding: 0 0.5rem;
padding: 0 0.75rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to current specs.

CITguy
CITguy commented Feb 22, 2019
View reviewed changes
src/helix-ui/styles/reset.less
@@ -25,7 +25,6 @@ html {
box-sizing: inherit;
}

@import 'reset/forms';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • moved valid resets to components/forms.less
  • all other resets removed (either useless or duplicate)

@CITguy CITguy force-pushed the dev-basic-form-controls--misc branch 3 times, most recently from 7017483 to 65bba6b Compare February 22, 2019 00:26
@CITguy CITguy added the PR: VIP label Feb 22, 2019
@CITguy CITguy force-pushed the dev-basic-form-controls--misc branch from 65bba6b to b87a589 Compare February 22, 2019 00:41
catsiller
catsiller approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev lgtm

100stacks
100stacks approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

Ryan A. Johnson added 5 commits February 22, 2019 12:03
chore(HXRadioElement): initialize <hx-radio>
6e212ed
refactor(HXCheckboxElement): refactor <hx-checkbox> logic for unwrapping
af2223b
docs(*): initialize docs for basic form controls
06ed2db 
* Radios (component)
* <hx-radio> (element)
* <hx-select> (element)

merge w radios
docs(*): refactor configuration forms across demos
9d49ad0 
* docs: Update forms in docs
  * Stop using `label > input`.
  * Use `input[id] ~ label[for]` to support incoming
    radios and checkboxes development.
  * Use future markup for checkboxes and radios.
* src: cleanup beta Form styles
  * prepare for upcoming development
chore(docs): add [data-mock-invalid] test helper
5e19f1a
@CITguy CITguy force-pushed the dev-basic-form-controls--misc branch from b87a589 to 5e19f1a Compare February 22, 2019 18:03
@CITguy CITguy merged commit 447a9f0 into dev-basic-form-controls Feb 22, 2019
@CITguy CITguy deleted the dev-basic-form-controls--misc branch April 3, 2019 21:42
@CITguy CITguy added the :shipit: shipped label Apr 4, 2019
@CITguy CITguy added this to the v0.16 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@catsiller catsiller catsiller approved these changes

Assignees
No one assigned
Labels
PR: VIP :shipit: shipped
Projects
None yet
Milestone
v0.16.x
Development

Successfully merging this pull request may close these issues.
4 participants
@CITguy @HelixUI @100stacks @catsiller