Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HXFormControlElement): centralize custom form control logic #470

Merged

Conversation

CITguy
Copy link
Contributor

@CITguy CITguy commented Mar 21, 2019

  • handles adding 'hx-changed' and 'hx-touched' attrs to communicate state

JIRA: SURF-1593, SURF-1594, SURF-1595

LGTM's

  • Dev LGTM
  • Zoom LGTM

@HelixUI
Copy link
Contributor

HelixUI commented Mar 21, 2019

Deploy preview for helix-ui ready!

Built with commit de10db0

https://deploy-preview-470--helix-ui.netlify.com

- handles adding 'hx-changed' and 'hx-touched' attrs to communicate state
@CITguy CITguy force-pushed the dev-bfc-phase2--HXFormControlElement branch from eb6512b to de10db0 Compare March 21, 2019 16:26
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev lgtm

Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async LGTM 👍

@CITguy CITguy merged commit d0fd2dc into dev-basic-form-controls Mar 21, 2019
@CITguy CITguy deleted the dev-bfc-phase2--HXFormControlElement branch March 21, 2019 16:54
@CITguy CITguy changed the title feat(HXFormControLElement): centralize custom form control logic feat(HXFormControlElement): centralize custom form control logic Apr 4, 2019
@CITguy CITguy added this to the v0.16 milestone Apr 4, 2019
@CITguy CITguy added the :shipit: shipped label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants