Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use patch instead of put to update router #352

Merged
merged 38 commits into from
Aug 7, 2018
Merged

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Jul 16, 2018


[all]

use patch instead of put to update router

[terraform]

use patch instead of put to update router. Fixes #1778.

[puppet]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-sql]

[chef-storage]

[ansible]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1780
depends: modular-magician/ansible#56
depends: GoogleCloudPlatform/puppet-google-compute#73

@danawillow
Copy link
Contributor Author

huh, any idea why this didn't generate anything for chef?

@nat-henderson
Copy link
Contributor

Is router already available in Chef? I didn't know that it was. I'll check on that.

@nat-henderson
Copy link
Contributor

Hm, it is, but I wonder if Chef knows about patch requests. Checking on that.

@nat-henderson
Copy link
Contributor

Got it, yeah, chef doesn't support update_verb.

nat-henderson and others added 19 commits July 17, 2018 13:44
rambleraptor and others added 18 commits July 25, 2018 14:29
* Write tiny bash script to properly test Terraform.

* Remove locking.
Tracked submodules are build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/terraform build/ansible.
@modular-magician modular-magician merged commit 79b370f into master Aug 7, 2018
@danawillow danawillow deleted the routerpatch branch December 7, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants