Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef Spanner + Fixing Puppet Spanner #377

Merged
merged 8 commits into from
Aug 1, 2018
Merged

Conversation

rambleraptor
Copy link
Contributor

First release of Chef Spanner + fixing issues with Puppet Spanner (both tests + examples were not working)


[all]

First release of Chef Spanner + fixing issues with Puppet Spanner

[terraform]

[puppet]

Fixing Puppet Spanner issues

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

First release of Chef Spanner

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-sql]

[chef-storage]

[ansible]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/chef-google-compute#41
depends: GoogleCloudPlatform/chef-google-sql#19
depends: GoogleCloudPlatform/chef-google-storage#15
depends: GoogleCloudPlatform/chef-google-container#7
depends: GoogleCloudPlatform/chef-google-dns#9

@rambleraptor
Copy link
Contributor Author

This also contains a small formatting change on Chef resources.

This is really, really important! There's broken things on Chef currently. Not sure why the tests aren't catching them.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed the Chef stuff, but the rest of it LGTM if the generated code LGTY.

@nat-henderson
Copy link
Contributor

Oh and the chef tests aren't catching them because of #236.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8e647d3) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit c1359e6c) have been included in your existing downstream PRs.

Tracked submodules are build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/terraform build/ansible.
@modular-magician modular-magician merged commit 83b5501 into master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants