-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef Spanner + Fixing Puppet Spanner #377
Conversation
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
This also contains a small formatting change on Chef resources. This is really, really important! There's broken things on Chef currently. Not sure why the tests aren't catching them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed the Chef stuff, but the rest of it LGTM if the generated code LGTY.
Oh and the chef tests aren't catching them because of #236. |
20bf887
to
81d7bdb
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 8e647d3) have been included in your existing downstream PRs. |
81d7bdb
to
30e3676
Compare
30e3676
to
cb2709b
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit c1359e6c) have been included in your existing downstream PRs. |
Tracked submodules are build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/terraform build/ansible.
First release of Chef Spanner + fixing issues with Puppet Spanner (both tests + examples were not working)
[all]
First release of Chef Spanner + fixing issues with Puppet Spanner
[terraform]
[puppet]
Fixing Puppet Spanner issues
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
First release of Chef Spanner
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-sql]
[chef-storage]
[ansible]