Make redis alternativeLocationId computed #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readability improvements for things I stumbled over the first time going through the philosophy doc. * Syntax highlighting * Consistent pluralization * gendered -> non-gendered pronoun
Added documentation for resource and imports resource fields
Note: This deletes the Git hook that enforced the presubmit script and required the NO_SQ=1 flag. You may have to fiddle a bit with your Git repo if it still uses this git hook
nat-henderson
approved these changes
Jul 27, 2018
Tracked submodules are build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/compute build/chef/sql build/chef/storage build/chef/container build/chef/dns build/terraform build/ansible.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make redis alternativeLocationId computed
Fixes hashicorp/terraform-provider-google#1669
[all]
[terraform]
Make redis alternativeLocationId computed
[puppet]
[puppet-compute]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-sql]
[chef-storage]
[ansible]