Add (Region)Autoscaler #307
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 6478c5b) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 1d88ab9) have been included in your existing downstream PRs. |
| @@ -322,7 +322,7 @@ func resource<%= resource_name -%>Update(d *schema.ResourceData, meta interface{ | |||
| <% elsif object.custom_code.encoder -%> | |||
| obj, err = resource<%= resource_name -%>Encoder(d, meta, obj) | |||
| <% end -%> | |||
| url, err := replaceVars(d, config, "<%= self_link_url(object) -%>") | |||
| url, err := replaceVars(d, config, "<%= update_url(object, object.update_url) -%>") | |||
There was a problem hiding this comment.
I think this logic belongs in core, and should be in PCA also. It does have to get done next quarter if not today.
There was a problem hiding this comment.
Fair. In the interest of keeping PRs smallish, I'm not going to do it now (doing so would merit adding Autoscaler to the other providers to show that it works, which means adding examples and testing to make sure they actually work. this is non-trivial enough that I'd like to take my time on it)
api/resource.rb
Outdated
| @@ -26,6 +26,7 @@ module Properties | |||
| attr_reader :description | |||
| attr_reader :kind | |||
| attr_reader :base_url | |||
| attr_reader :update_url | |||
There was a problem hiding this comment.
Can you add a comment here explaining what this is for? And add it to the spreadsheet of resource attributes?
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit ca8937d) have been included in your existing downstream PRs. |
Readability improvements for things I stumbled over the first time going through the philosophy doc. * Syntax highlighting * Consistent pluralization * gendered -> non-gendered pronoun
Added documentation for resource and imports resource fields
Note: This deletes the Git hook that enforced the presubmit script and required the NO_SQ=1 flag. You may have to fiddle a bit with your Git repo if it still uses this git hook
Merged PR #308.
Merged PR #310.
Tracked submodules are build/puppet/compute build/puppet/sql build/puppet/storage build/chef/compute build/chef/sql build/chef/storage build/terraform build/ansible.
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 8f4c816) have been included in your existing downstream PRs. |
Adds Autoscaler and RegionAutoscaler to Magic Modules.
For now, I've excluded them from the other providers because there's still a little bit of work to be done there around the custom
update_url(and we'll want to decide if we want to release RegionAutoscaler before RegionInstanceGroupManager exists, and potentially other stuff), but I'd also be ok with going in and making those changes if you think it's important to do nowOther things this does besides just raw generation:
update_urlfield for resources that support PUTting the whole resource but have a custom URL involved in that.[all]
[terraform]
Add generated google_compute_autoscaler and google_compute_region_autoscaler resources. Because this adds the ability to import by more than just the name, we can get rid of all the code in resource_compute_autoscaler.go that tries to find the autoscaler in the provider-specified region.
[puppet]
[puppet-compute]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-sql]
[chef-storage]
[ansible]