Forwarding rule bugfix #310
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit a3b8be2) have been included in your existing downstream PRs. |
| } | ||
| url, err := replaceVars(d, config, "https://www.googleapis.com/compute/v1/projects/{{project}}/regions/{{region}}/<%= url_name -%>/") | ||
| url, err := replaceVars(d, config, "https://www.googleapis.com/compute/v1/projects/{{project}}/regions/{{region}}/") |
There was a problem hiding this comment.
Won't this just give us a URL that doesn't point to a specific resource type?
There was a problem hiding this comment.
I've added a comment to explain, but yes.
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit ce3bf3a) have been included in your existing downstream PRs. |
Readability improvements for things I stumbled over the first time going through the philosophy doc. * Syntax highlighting * Consistent pluralization * gendered -> non-gendered pronoun
Added documentation for resource and imports resource fields
Note: This deletes the Git hook that enforced the presubmit script and required the NO_SQ=1 flag. You may have to fiddle a bit with your Git repo if it still uses this git hook
Merged PR #308.
Tracked submodules are build/puppet/compute build/puppet/sql build/puppet/storage build/chef/compute build/chef/sql build/chef/storage build/terraform build/ansible.
Self links might not be target pools. They can also be VPN Gateways, and possibly others. This overrides a change made to the expander (due to the
resourcereftype) but still allows a non-complete self_link. If just a name is provided, the self link will point to a forwarding rule.[all]
[terraform]
Fix bug with forwarding rule when used with non-targetpool target.