Default key_type is Api::Type::String #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
| @@ -494,6 +494,7 @@ class NameValues < Composite | |||
|
|
|||
| def validate | |||
| super | |||
| default_value_property :key_type, Api::Type::String.to_s | |||
There was a problem hiding this comment.
Do you need that and check_property?
There was a problem hiding this comment.
Yeah. If you override the value (for whatever reason), we need to check that the value is still of type ::String
nat-henderson
approved these changes
Jul 25, 2018
Tracked submodules are build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/compute build/chef/sql build/chef/storage build/chef/container build/chef/dns build/terraform build/ansible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default key_type is Api::Type::String.
We can override, but we use Api::Type::String in all examples so far (and it seems strange to use anything else for JSON requests)
[all]
Default key_type is Api::Type::String
[terraform]
[puppet]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-sql]
[chef-storage]
[ansible]