Deploy Checklist: New Expensify 2021-09-01

[OSBotify]

Release Version: 1.0.91-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [CP Staging] Remove duplicate form fields #4117
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• Fix staging due to undefined Onyx key #4286
• Fix broken list components on staging #4300
• Patch for PR #4190  #4322
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Fix User is able to upload a file larger than 50mb #4358
• Fix: Selecting a language does not update in real time #4366
• Fix: Infinite loader on login #4397
• Attempt at fixing race #4416
• Race fix attempt 2 #4436
• fix: message alignment #4503
• [No QA] Make a dummy change for a test PR #4568
• Fix ExpensiInput autoFocus & tab Focus #4593
• Hide Password mismatch incase both the passwords are empty #4607
• Check for value before checking length #4613
• Clear storage immediately on sign out #4614
• Fix: autofill on the BaseExpensiInput #4632
• Update state picker component in VBA flow #4633
• Changed Personal and Company Address Labels #4636
• Change picker value color #4641
• Update withOnyx to fix prop dependent key updates #4676
• [CP Staging] Use props not state in NewPasswordForm #4684
• Bump Onyx version to fix recent regressions #4706
• Fix enable payments page with another Onyx update #4721
• Handle errorText in TextInputWithLabel #4741
• Display the /bank-account/requestor page #4742
• Fix StagingDeployBlocker where chat draft message is kept in the test input while switching chats #4761
• Fix: marker is not clickable on android #4774
• Remove expensifySMS domain from the request IOU page #4803
• Update fastlane version #4804
• Remove unnecessary style causing bug in android #4807
• fix count when LHN is open on mobile #4865
• Download Filename and Tooltip to Download #4871
• Remove redundant placeholder for login form #4918
• Add icons to buttons, fix inboxcallbutton text size #4919
• [No QA] Use pretext in chrerry pick workflow to tag mobile-deployers #4925
• Make dummy change #4934
• Workspace Admin Translation fix, few es copy changes #4954
• Grab iOS version from release event #4957
• Error message shown out of place in VBA flow #4960
• Allow builds to distribute to external testers #4961
• Remove internationalization beta #4967
• [No QA]: SignInpage Props Warning #4979

Deploy Blockers:

• TEST - I'll delete it soon #4985
• [HOLD for payment 2021-11-04] Chat - No results found message displayed even when results are found  #4993

cc @Expensify/applauseleads

[isagoico]

@roryabraham Are we good to start QA here? Or will you add the lock label and let us know when it's ready?

[roryabraham]

@isagoico Feel free to begin QA when ready! All the deploy systems are fixed and we should be back to normal operation now. The only thing that's changed long-term is that a mobile-deployer will close the checklist to trigger the prod deploy

[isagoico]

Starting QA!

[roryabraham]

I was unable to reproduce #4993 – not sure the best way forward. Can we retest or maybe find more specific instructions on how to reproduce the issue?

[isagoico]

Regression is finished!
Issues found:

1. [HOLD for payment 2021-12-06] Change Password - Error message not displayed in red for incorrect new password #4995
2. Message "PDF is loading..." isn't displayed when PDF is loading in Preview #4997
3. [HOLD for payment 2021-11-04] mWeb - Create group - Keypad remains open when selecting a user and scrolling through the list is not comfortable #4994
4. [HOLD for payment 2021-11-04] Chat - No results found message displayed even when results are found  #4993

PRs are finished.
No comments added 🎉

Thanks!

[roryabraham]

Since there are no deploy blockers, it seems like we are good to run a prod deploy 🚀

[roryabraham]