Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dummy change #4934

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Make dummy change #4934

merged 1 commit into from
Aug 30, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Dummy change outlined as part of testing plan here.

Tests

  1. Merge this PR
  2. Have a non-mobile-deployer attempt to manually CP it. That should fail.
  3. Have a mobile-deployer attempt to manually CP it. That should work.

QA Steps

None.

@roryabraham roryabraham self-assigned this Aug 30, 2021
@roryabraham roryabraham requested a review from a team as a code owner August 30, 2021 22:50
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team August 30, 2021 22:50
@thienlnam thienlnam merged commit e5c800f into main Aug 30, 2021
@thienlnam thienlnam deleted the Rory-DummyPR branch August 30, 2021 22:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

2 passed 🎉

github-actions bot pushed a commit that referenced this pull request Aug 30, 2021
Make dummy change

(cherry picked from commit e5c800f)
@roryabraham
Copy link
Contributor Author

3 passed 🎉

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.0.88-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.0.89-0 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants