Message "PDF is loading..." isn't displayed when PDF is loading in Preview

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Select any conversation
4. Attached a PDF and sent it
5. After PDF is loaded click on it

Expected Result:

Message as "PDF is loading..." is displayed when PDF is loading in Preview

Actual Result:

Message as "PDF is loading..." is displayed when PDF is loading in Preview

Workaround:

None needed, visual issue.

Platform:

Where is this issue confirmed?

• Android

Version Number: 1.0.91-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5219503_Screen_Recording_20210901-150201_New_Expensify.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Dal-Papa]

Tagging @parasharrajat since he worked on this. I'm pretty sure the default text is Loading PDF... from the documentation so if we don't see it in the Android platform it might be that they didn't implement it for mobile ? We never explicitly specify the text ourselves.

[isagoico]

Issue reproducible during KI retests

[Dal-Papa]

Bump to @parasharrajat otherwise this might be a :donothing: since it's at the library level.

[parasharrajat]

I am on vacation. Back on 8.

[MelvinBot]

@Dal-Papa Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

@Dal-Papa Sorry for catching up late here.
We can update this if you want.

On native, we have a prop activityIndicator which can be set as activityIndicator={<Text>Loading PDF…</Text>} to match the web.

Also, We can change both native and web to show the same loading indicator if Loading PDF… is not friendly.
For example,

• showing our FullScreenLoadingIndicator for native
  activityIndicator={<FullScreenLoadingIndicator visible />}
• showing our FullScreenLoadingIndicator for web.
  loading={<FullScreenLoadingIndicator visible />}

[Dal-Papa]

Awesome, thanks for the pointers @parasharrajat !

[isagoico]

Issue reproducible during KI retests.

[MelvinBot]

@Dal-Papa Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

Let me know what needs to be done here. I can send a PR.

[MelvinBot]

@Dal-Papa Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@Dal-Papa Still overdue 6 days?! Let's take care of this!

[isagoico]

Issue reproducible during KI retests.

[Dal-Papa]

Was OOO last week, will provide an update soon.