Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enable payments page with another Onyx update #4721

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Fix enable payments page with another Onyx update #4721

merged 3 commits into from
Aug 18, 2021

Conversation

marcaaron
Copy link
Contributor

Details

See linked Onyx PR Expensify/react-native-onyx#100

Fixed Issues

$ #4719

Tests

QA Steps

  1. Navigate to /enable-payments verify the page loads and does not show a white screen

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner August 18, 2021 01:17
@marcaaron marcaaron self-assigned this Aug 18, 2021
@marcaaron marcaaron changed the title Fix enable payments page with another Onyx update [HOLD] Fix enable payments page with another Onyx update Aug 18, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team August 18, 2021 01:17
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron mentioned this pull request Aug 18, 2021
Merged
@marcaaron marcaaron changed the title [HOLD] Fix enable payments page with another Onyx update Fix enable payments page with another Onyx update Aug 18, 2021
@marcaaron
Copy link
Contributor Author

Off hold now 🙇

@marcaaron marcaaron merged commit 456ba25 into main Aug 18, 2021
@marcaaron marcaaron deleted the marcaaron-updateOnyx3 branch August 18, 2021 17:29
github-actions bot pushed a commit that referenced this pull request Aug 18, 2021
@marcaaron
Merge pull request #4721 from Expensify/marcaaron-updateOnyx3
5e728e5 
Fix enable payments page with another Onyx update

(cherry picked from commit 456ba25)
This was referenced Aug 18, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.0.86-3 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

This was referenced Sep 1, 2021
Closed
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctkochan22 ctkochan22 ctkochan22 approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @ctkochan22