Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Filename and Tooltip to Download #4871

Merged

Conversation

akshayasalvi
Copy link
Contributor

@akshayasalvi akshayasalvi commented Aug 27, 2021

@thienlnam Can you please review this?

Details

  1. Added fileName to the download function
  2. Added Tooltip to the download icon

Fixed Issues

$ #4601
$ #4870
$ #4868

Tests

  1. Screenshot attached for tooltips in Web and Desktop
  2. Filename will be tested once pushed to staging

QA Steps

  1. We need to test if the fileName that is downloaded is same as the filename shown in the preview
  2. Need to verify that Tooltip is visible for the download icons

Tested On

  • Web
  • [] Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-27 at 12 34 54 PM

Mobile Web

Desktop

Screenshot 2021-08-27 at 12 37 45 PM

iOS

Android

@akshayasalvi akshayasalvi requested a review from a team as a code owner August 27, 2021 07:09
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team August 27, 2021 07:10
@parasharrajat
Copy link
Member

NOTE: This PR should be Cp'ed.

Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit e04a689 into Expensify:main Aug 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@akshayasalvi
Copy link
Contributor Author

Thanks for merging. IS it deployed immediately? or we'll update the label?

@thienlnam
Copy link
Contributor

@akshayasalvi The label got applied after the PR was merged so I'll have to get it CPed manually

github-actions bot pushed a commit that referenced this pull request Aug 27, 2021
Download Filename and Tooltip to Download

(cherry picked from commit e04a689)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @AndrewGable in version: 1.0.88-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@isagoico
Copy link

It worked 🎉
image

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants