Deploy Checklist: New Expensify 2024-04-08

[github-actions]

Release Version: 1.4.61-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• phase1: fix emoji picker refocus issue #35572
• feat: add delete option to deletable report fields #36039
• [Audit][Implementation] hasDraft replacement #37281
• Fix/37095: Tag list show required #37388
• [TS migration] Migrate VideoPlayer component files to TypeScript #37613
• [Onboarding - Stage 1] Onboarding Flow #37733
• Fix - mWeb auto focus on reply in thread #37929
• chore: bump react-native-onyx to 2.0.23 #38114
• Create Invite-members-and-assign-roles.md #38479
• fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542
• feat: Add temporary focus to enabled option in workspace initial page #38546
• Update Fallback Avatar to Support Themes  #38674
• Fix the optimistic GBR for chats with money requests #38675
• [NO QA] Update Card typescript Types #38747
• Enable searching for workspaces/rooms by their participants #38887
• [TS migration] Migrate remaining FlatList files to TypeScript #38936
• BaseShareLogList list refactor #38942
• Replace OptionsSelector with SelectionList - part 1 #38994
• [TS migration] Migrate 'PDFView' component to TypeScript #39011
• Refactor/36648 wallet enablement flow #39038
• [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage to TypeScript #39059
• Update and rename Categories.md to Create-categories.md #39180
• Create Set-up-category-automation.md #39196
• [No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript #39206
• Create Navigate-multiple-workspaces.md #39212
• Update and rename Budgets.md to Set-budgets.md #39213
• Update Troubleshooting.md to include import troubleshooting #39220
• User can access the background list using the arrow keys while the RHP is open #39327
• Update and rename Per-Diem-Expenses.md to Track-per-diem-expenses.md #39359
• Update and rename Per-Diem.md to Enable-per-diem-expenses.md #39362
• Shortcut - Workspace avatar next to request shortcut does not update when it is changed #39368
• Create Enable-two-factor-authentication.md #39382
• [Fix]: New chat shows time zone for Unvalidated Accounts #39384
• Fix: Task report does not scroll to bottom after editing #39390
• fix: Fix playing Shutter Sound in Scan Receipt #39400
• Workspace switcher - Workspace switcher reopens after selecting a workspace with keyboard #39402
• Hide notification badge on iOS app reinstall #39410
• update getPartialStateDiff.ts fullscreen diff #39442
• Delete docs/articles/expensify-classic/reports/Attendee-Tracking.md #39448
• Align offline receipt view for one-transaction and multi-transaction views #39465
• Optimizing getPersonalDetailByEmail using key-value pair object mapping #39477
• [NoQA] Fix failing lockStagingDeploys job #39480
• fix: workspace currency can be changed without existing distance rates #39484
• Unify the distance rates enabled label styles with other feature row styles #39557
• Fix submit and close next steps for optimistically created policy #39563
• [HelpDot] New expensify - rename categories and simplify descriptions #39574
• Use correct isGroupChat condition when creating a report #39575
• [HelpDot] rename olddot hubs and update description #39576
• Fix/App does not redirect to group chat when splitting bill via Shortcut #39577
• Bump react-fast-pdf #39578
• [No QA] Add debug logs to awaitStagingDeploys.ts #39606
• Fix sign in button remains when login new user via public room #39608
• Disable default category selector if all categories are disabled #39645
• Update redirects.csv for tax and copilots and delegates #39648
• feat: add missing styles for workspace menu items #39657
• Publish Expense-Rules.md under the Expenses category #39661
• Delete docs/articles/expensify-classic/reports/Expense-Rules.md #39662
• Publish Currency.md under the Workspaces category #39663
• Delete docs/articles/expensify-classic/reports/The-Expenses-Page.md #39670
• fix autofocus on edit tax amount text input #39675
• Fix split bill with one user from QAB shows not found page #39680
• Fix optimistic system message when updating tax amount #39682
• Revert "Replace OptionsSelector with SelectionList - part 1" #39702
• Replace OptionsSelector with SelectionList part 1 #39711
• Change the UI copy from Connections to Accounting #39729
• Update redirects.csv #39750
• [CP Staging] Revert "Bump react-fast-pdf" #39869
• [CP staging] fix Concierge chat flickers non-stop after redirecting from Old Dot #39896
• [CP Staging] Fix: Composer - Pointer returns to previous line when adding new line #39934
• [CP Staging] Fix - Welcome modal is displayed on Abracadabra page after sign in #39938
• [CP staging] Revert "Align offline receipt view for one-transaction and multi-transaction views" #39968
• Check if the OpenApp has finished or not before updating Onyx data #39979
• [CP Staging] Revert "Enable searching for workspaces/rooms by their participants" #40019

Deploy Blockers:

• [HOLD for payment 2024-04-15] [$500] Start chat - App shows data from User A after logging out of User A and logging in with User B #39710
• Web - Draft - Chat with draft takes some time to move up in LHN with pencil icon #39821
• [$250] Chat - Space Not Added After Emoji Selection in Composer #39822
• [PAID] [$250] IOU - Fields in transaction thread appear at the top of the page in combined IOU report #39824
• [HOLD for payment 2024-04-25] Taxes - id_TAX_EXEMPT appears in the list when there are more than 8 tax rates #39825
• Wallet - Left side bar is LHN instead of Settings after adding a bank account #39827
• Onboarding - Onboarding video loads infinitely with console error #39828
• [HOLD for payment 2024-04-25] [$500] OD redirection - Concierge chat flickers non-stop after redirecting from Old Dot to New Dot #39831
• [HOLD for payment 2024-04-25] Attachment - Wrong PDF is opened #39833
• [$250] [Awaiting Payment 30th April] [Guided Setup] Onboarding - Modal can bn be dismissed by ESC key #39834
• [HOLD for payment 2024-04-25] [$500] Composer - Pointer returns to previous line when adding new line #39836
• [HOLD for payment 2024-04-25] [HOLD for payment 2024-04-17] [Guided Setup] [$250] Sign up - Welcome modal window on Abracadabra page #39837
• Web - Expense - Default tax rate and first tag item are not highlighted #39838
• [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] Web - Features - Feature row in left side bar appears with delay after the page opens on the right #39841
• [$250] Web - IOU - Report fields are not auto focused #39845
• Wallet - Back button in Wallet loops between Wallet and Add bank account #39847
• LHN - LHN displayed blank for a 1-2 second when user rapidly scrolled up #39849
• [$500] Desktop - App redirection when logged in with different accounts causes desktop logout #39851
• [$250] mWeb - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones #39853
• [HOLD for payment 2024-04-25] [Guided Setup] [$250] Android - Onboarding video can be scrubbed through on iOS app, but not on Android app #39855
• [HOLD for payment 2024-05-06] App lags and every actions happen with delay #39864
• [$250] Search - Infinite loading when searching for a non existing user #39866
• [Awaiting Payment][$250] PDF - "Send" button is missing on password protected PDF preview #39870
• Wallet - Offline indicator appears below the card and not the bottom of page #39900
• [HOLD for payment 2024-06-06] [Guided Setup] [$250] Login - "Here is your magic code" appears briefly before the abracadabra page #39904
• [$500] Deeplink – Infinite skeleton loading when navigate via Concierge link and log in as new user #39907
• [HOLD for payment 2024-07-17][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight #39909
• [$250] Deeplink – Previous conversation opens for a moment when navigate via non-existing link #39914
• [Simplified Collect: Tags] Tags - "Required" text is missing for required tags #39916
• [HOLD for payment 2024-05-02] [Guided Setup] [Hold #39687] Onboarding - Font in onboarding flow is cut off when device font size is on the smaller end #39918
• Expense - Report field is not removed when deleted #39919
• [Guided Setup] Onboarding - Video is not dismissed after refreshing the page #39920
• [HOLD for payment 2024-04-25] Expense - GBR appears briefly in LHN when Schedule submit is enabled and admin requests money #39923
• [HOLD for payment 2024-05-02] [Guided Setup] [Hold #39687] Web - Onboarding - highlight shows up around onboarding video when clicking volume button #39925
• [HOLD for payment 2024-04-29][$250] Share log - Chat icon is highlighted in Settings after returning from share destination #39926
• [$250] IOU - Upload receipt with PDF file showing error #39967
• [HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot. #39971
• [$250] Pasting data in chat puts the cursor in the wrong position #40025

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

Checking off #39710 as I forgot to remove the label this morning 😵‍💫

[mountiny]

Demoted #39827

[mountiny]

Demoted #39841

[mountiny]

#39834 fixed by backend change

[luacmartins]

Demoted #39838

[mountiny]

Demoted #39845
Demoted #39847

[marcaaron]

Demoted #39851

[mountiny]

demoted #39855

[jasperhuangg]

Demoted #39853 NAB

[kavimuru]

Regression is 84% progress.

#38887 failing with #35257, bug is not fixed and repro in all the platforms, comment
#39390 failing with #38833 issue not fixed in mweb and android, comment

[srikarparsi]

Hey, is it okay to check off #39825, I don't think it's a deploy blocker because it's related to this feature and this item was similarly checked off. I've been working on it for about 2 hours and have left some updates on the issue. I have a little bit of other things to finish up today so just wanted to check if I can move to those before stopping work on this one.

[gijoe0295]

#39390 failing with #38833 issue not fixed in mweb and android, #39390 (comment)

Would be fixed after #39685 was merged. The issue is not constantly reproducible and does not break any functionality so I think we can demote it.

[Julesssss]

#39825 was checked off here

[kavimuru]

@Julesssss Regression is completed.

Unchecked PRs:
#36039 failing with #39919
#37733 - failing with #39834
#38675 - failing with #39923
#38887 failing with #35257, bug is not fixed and repro in all the platforms comment
#39038 failing with #39847
#39390 failing with #38833 issue not fixed in mweb and android - checking off as per this comment

Open Blockers:
#39824
#39831
#39833
#39836
#39837
#39864
#39904
#39907
#39919
#39920
#39923
#39925
#39926

[amyevans]

Demoted #39926

[mountiny]

demoted #39904

[mountiny]

Demoted:

• Expense - Report field is not removed when deleted #39919
• [Guided Setup] Onboarding - Video is not dismissed after refreshing the page #39920
• [HOLD for payment 2024-05-02] [Guided Setup] [Hold #39687] Web - Onboarding - highlight shows up around onboarding video when clicking volume button #39925

[Julesssss]

Demoting #39864 as it isn't reproducible, and is a generic perf issue

[Julesssss]

Checking off #39923 as we've merged a PR already and it is a minor issue

[cristipaval]

Demoted #39907

[amyevans]

Checked off 39833 following CP fix and retest

[kavimuru]

#39896 failing in Desktop due to #39851. Other platforms are pass
#39938 failing in mweb with #39932

[mountiny]

checked #39896 off as the follow up issue is being handled

[Julesssss]

Checked off #39968 which fixed a blocker by reverting #39465

[Julesssss]

• Checking off feat: add delete option to deletable report fields #36039 as not a blocker
• Checking off [$250] [Awaiting Payment 30th April] [Guided Setup] Onboarding - Modal can bn be dismissed by ESC key #39834 and [Onboarding - Stage 1] Onboarding Flow #37733 as this is a new feature
• Checking off Fix the optimistic GBR for chats with money requests #38675 as demoted
• Checking off Enable searching for workspaces/rooms by their participants #38887 as a long existing and minor issue -- I commented on the issue
• Checking off Refactor/36648 wallet enablement flow #39038 as the bug is hidden behind a flow not accessible to users

[Julesssss]

#39938 confirmed not a blocker here

[Julesssss]

As discussed here in Slack, we will not mark #39971 as a blocker. It's only reproducable when triple clicking before copy/pasting and is part of a new feature.

[Julesssss]

• Github Status ✅
• Firebase crashes ✅
  • Android:
    • More instances of a long running crash, with no increase -- no need to hold
    • The only new crash has one instance
  • iOS:
    • No new crashes
    • A build from last week had a spike in crashes

[Julesssss]

App timing

A) Starting at the beginning of the month, there is a spike in homepage initial render on Desktop:

- This is not affecting the other platforms, and at the same time we see a major improvement for iOS:


As the Desktop regression has also been deployed for 10 days, this shouldn't block the deploy, but I will look into this and share in relevant channels after closing this release

B) QA reported a performance regression on Android where rendering is taking an average of 20/30 seconds, which we have data for. This doesn't seem to be reproducable, but I am holding the deploy while we investigate further to be sure about this.

[Julesssss]

As discussed, I'm going to ship as there is no real path for resolving this vague and currently unreproducable Android performance regression.

[Julesssss]

Performance regression is being worked on here

[roryabraham]

heads up that we just CP'd a fix to a fire room - let's make sure that PR is tested and goes out too: https://expensify.slack.com/archives/C07J32337/p1712765918676959

[rlinoz]

Checking off #40025

[Julesssss]

checking off #39979, the fire exists in prior releases and although not confirmed fixed, hasn't further broken the app

[Julesssss]

Status from earlier are still valid: #39807 (comment)

[Julesssss]

There's an issue with Github codespaces, which is not relevant to our deploy

Investigating - We are investigating reports of degraded performance for Codespaces
Apr 10, 2024 - 16:12 UTC

[Julesssss]