Wallet - Left side bar is LHN instead of Settings after adding a bank account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #39038

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Profile > Wallet
3. Add /add-bank-account-refactor to the URL and navigate to it
4. Add a bank wallet

Expected Result:

After adding a bank account, the left side bar and the right screen will open settings page

Actual Result:

After adding a bank account, the left side bar is LHN, while the right screen is Wallet page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442198_1712581064243.BA.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[rlinoz]

Looking at the videos in the original PR it looks like it is working as intended, maybe @mountiny or @shawnborton can confirm?

[shawnborton]

Hmm I don't think anyone would directly access the page called /add-bank-account-refactor - that might just be something temporary as we work through all of the styles here? Definitely curious for @mountiny 's take but I have a feeling we can close this one out?

[c3024]

I think we map the central pane to RHP in these cases for deeplink cases. In this case by adding

SCREENS.SETTINGS.ADD_BANK_ACCOUNT_REFACTOR,

here

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Line 35 in dd30d13

SCREENS.SETTINGS.WALLET.CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS,

Also, this route being sub-part of wallet shouldn't this be in WALLET here

App/src/SCREENS.ts

Line 70 in dd30d13

WALLET: {

instead of directly in SETTINGS here

App/src/SCREENS.ts

Line 35 in dd30d13

ADD_BANK_ACCOUNT_REFACTOR: 'Settings_Add_Bank_Account_Refactor',

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN changes when for wallet routes

What is the root cause of that problem?

We have not mapped all routes related to add bank account/ add debit card for wallet pages:

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Lines 24 to 36 in dd30d13

	[SCREENS.SETTINGS.WALLET.ROOT]: [
	SCREENS.SETTINGS.WALLET.DOMAIN_CARD,
	SCREENS.SETTINGS.WALLET.CARD_GET_PHYSICAL.NAME,
	SCREENS.SETTINGS.WALLET.CARD_GET_PHYSICAL.PHONE,
	SCREENS.SETTINGS.WALLET.CARD_GET_PHYSICAL.ADDRESS,
	SCREENS.SETTINGS.WALLET.CARD_GET_PHYSICAL.CONFIRM,
	SCREENS.SETTINGS.WALLET.TRANSFER_BALANCE,
	SCREENS.SETTINGS.WALLET.CHOOSE_TRANSFER_ACCOUNT,
	SCREENS.SETTINGS.WALLET.ENABLE_PAYMENTS,
	SCREENS.SETTINGS.WALLET.CARD_ACTIVATE,
	SCREENS.SETTINGS.WALLET.REPORT_VIRTUAL_CARD_FRAUD,
	SCREENS.SETTINGS.WALLET.CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS,
	],

What changes do you think we should make in order to solve the problem?

Map all the routes related to adding bank account/ debit card for wallet page;

App/src/ROUTES.ts

Lines 110 to 113 in dd30d13

	SETTINGS_ADD_DEBIT_CARD: 'settings/wallet/add-debit-card',
	SETTINGS_ADD_BANK_ACCOUNT: 'settings/wallet/add-bank-account',
	SETTINGS_ADD_BANK_ACCOUNT_REFACTOR: 'settings/wallet/add-bank-account-refactor',
	SETTINGS_ENABLE_PAYMENTS: 'settings/wallet/enable-payments',

What alternative solutions did you explore? (Optional)

N/A

[mountiny]

@rlinoz thanks for the ping

This is not used flow yet and its middle of development hence the special route. We can close this

@koko57 will address this in the future work, the page needs to be added to the correct mapping

[koko57]

yes, it's temporary as the refactor is being worked on - I'll take care of that in one of the following PRs

cc @mountiny @shawnborton