Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Desktop - App redirection when logged in with different accounts causes desktop logout #39851

Closed
2 of 6 tasks
kbecciv opened this issue Apr 8, 2024 · 30 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481895
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisites: The user is logged out in the browser and clears the cache before starting the steps.
Desktop app: Logged out

  1. Open staging.new.expensify.com and log in with User A
  2. Open the Desktop app and log in with User B
  3. As User A, open any profile in the browser and reload the page to trigger the open app modal
  4. Click on "Open app"

Expected Result:

User profile page for account A is displayed in the desktop app

Actual Result:

App redirection when logged in with different accounts causes desktop logout.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442506_1712592956862.Desktop_app_gets_logged_out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f7298781dc451347
  • Upwork Job ID: 1777413402440323072
  • Last Price Increase: 2024-04-09
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

Issue is not reproducible in production

Bug6442506_1712593188805.PROD_-_NOT_REPRO_-__v1.4.60-13.mp4

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

It might be related to the onyx bump, I have seen issues like this related to onyx changes in the past.

I do think however that this does not have to be a blocker since its very rare flow of having web and desktop and 3 accounts.

I suggest removing the DB label and marking this as External to get contirbutors look into this. @marcaaron @Julesssss thoughts?

@marcaaron
Copy link
Contributor

Since this is related to signing in with multiple accounts (edge case for most people) going to remove the blocker label.

@marcaaron marcaaron removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 8, 2024
@marcaaron marcaaron removed their assignment Apr 8, 2024
@marcaaron marcaaron added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title Desktop - App redirection when logged in with different accounts causes desktop logout [$250] Desktop - App redirection when logged in with different accounts causes desktop logout Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f7298781dc451347

Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

@marcaaron Testers have also encountered issues with signing in via Google and Apple in the Desktop app.

Directly.redirection.mov

@Julesssss
Copy link
Contributor

@marcaaron Testers have also encountered issues with signing in via Google and Apple in the Desktop app.

That looks related to the deep-link redirection. Is this only happening for users on multiple accounts/clients? Because if so I think that also doesn't need to be a blocker.

@mountiny mountiny changed the title [$250] Desktop - App redirection when logged in with different accounts causes desktop logout [$500] Desktop - App redirection when logged in with different accounts causes desktop logout Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Upwork job price has been updated to $500

@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

Bumping the price to 500 to get more eyes in, the google sign in does not look good

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@hungvu193
Copy link
Contributor

Still looking for proposals 👀

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Apr 16, 2024

Thanks vit.

Unable to reproduce when navigating from staging.new.expensify.com in Chrome to Staging desktop.
Also unable to reproduce when navigating from new.expensify.com in Chrome with a different account to staging Desktop.

Adding retest-weekly and bumping to weekly. Removed Help Wanted too

@mallenexpensify mallenexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 16, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@hungvu193 @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mallenexpensify mallenexpensify added the Needs Reproduction Reproducible steps needed label Apr 23, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2024
@mallenexpensify
Copy link
Contributor

Still holding on retest and... there's another web>desktop issue, think it's the one below

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mallenexpensify
Copy link
Contributor

Also wasn't able to reproduce so I'm closing. If you try/test and are able to @hungvu193 , please comment and I'll reopen. (it did forever-load though, which isn't ideal. Not seeing errors in the console, network tab screenshot below)
image

image

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
@mallenexpensify
Copy link
Contributor

After a hard refresh it loaded but it's only showing 1 chat in LHN (and I have a ton in my test account)
image

@hungvu193
Copy link
Contributor

Also wasn't able to reproduce so I'm closing. If you try/test and are able to @hungvu193 , please comment and I'll reopen. (it did forever-load though, which isn't ideal. Not seeing errors in the console, network tab screenshot below)

image image

Yeah I can't seem to reproduce this one as well

@hungvu193
Copy link
Contributor

Can we close it then?

@mallenexpensify
Copy link
Contributor

Yeah, I think we can close. Comment/reopen if you disagree or if you're able to reliably reproduce.

@lanitochka17
Copy link

Issue is still reproducible on the latest build 1.4.77-0

desktop.logout.mp4

@lanitochka17 lanitochka17 reopened this May 29, 2024
@melvin-bot melvin-bot bot added the Overdue label May 29, 2024
@hungvu193
Copy link
Contributor

I still can't reproduce.

Screen.Recording.2024-05-30.at.09.27.16.mov

Also there was some issues with desktop login, that was fixed (I think that's why this issue was reproduced).
More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1717012386285909

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@mallenexpensify
Copy link
Contributor

ooooof. I have a hunch this has to do with a bug that got fixed yesterday where users were getting signed out. Gonna leave retest-weekly on here to see if this persists next week (cuz the PR was 🍒 picked yesterday)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@mallenexpensify
Copy link
Contributor

Closing since it's not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants