[Guided Setup] Onboarding - Video is not dismissed after refreshing the page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37733
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by:

Action Performed:

1. Go to staging.new.expensify.com/onboarding.
2. Enter name > Next.
3. Select an option > Next.
4. When the video is playing, refresh the page.

Expected Result:

On page refresh the onboarding video disappears, even if user did not close it explicitly (PR step 18).

Actual Result:

After refreshing the page, the onboarding video does not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6443101_1712638936444.20240409_125921.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[mountiny]

Not a blocker as this is not accessible for the new users, I am helping with this project now so taking over

[Julesssss]

Excellent 👍

[cdOut]

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I will work on this issue.

[cdOut]

I'm working on this, I'll post a solution as a commit in the onboarding flow enabled PR.

[hoangzinh]

I reported this bug during PR review, and it appears that we changed behavior here #37733 (comment)

[cdOut]

I reported this bug during PR review, and it appears that we changed behavior here #37733 (comment)

@shawnborton Is this still the way we want to go forward with this one? If yes then we can close this issue and if we want to go back to the previous implementation then I have a solution ready to be pushed.

[shawnborton]

Yeah, I thought we decided that refreshing the page is the same as accessing the current page URL, and if the current page url is for showing a video, then it makes sense that refreshing would show the video again. Maybe I am missing something though? Cc @Expensify/design for a gut check, but seems like we can close this one.

[dannymcclain]

Yeah, I thought we decided that refreshing the page is the same as accessing the current page URL, and if the current page url is for showing a video, then it makes sense that refreshing would show the video again. Maybe I am missing something though? Cc @Expensify/design for a gut check, but seems like we can close this one.

Totally agree. I remember us deciding this in Slack. This looks like expected behavior to me and I think we can close.

[dubielzyk-expensify]

I'm aligned with that. We also wanted the potential ability to link to this video which is why this is good as is.

Worth noting that even if people land on this video after having just seen it, there's no real damage in that :)

[kadiealexander]

Agree with everyone here, closing the issue!