Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate component framework to Lit #10310

Closed
jcfranco opened this issue Sep 13, 2024 · 2 comments
Closed

Migrate component framework to Lit #10310

jcfranco opened this issue Sep 13, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Milestone
2024-11-26 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented Sep 13, 2024 •
edited by DitwanP
Loading

Priority impact

p - high

Summary

Migrating to Lit will enable us to leverage key features that will streamline development and improve our overall workflow.

Blocked issues: #8249, #220, #8307, #9057, #9090, #10038, #10237, #10263, #9089, #7631, #9494, #10399, #10423, #10422, #10376, #991, #10619, #10227, #9260

Desired Outcome

Components are fully Lit-based.

Resources

No response

Related

#10356
#10352
#10344
#8073 (comment) (might address potential bug)
@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2024
@github-actions github-actions bot added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Sep 13, 2024
@jcfranco jcfranco mentioned this issue Sep 13, 2024
Closed
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Sep 13, 2024
@geospatialem geospatialem added estimate - 8 Requires input from team, consider smaller steps. and removed needs triage Planning workflow - pending design/dev review. labels Sep 13, 2024
@geospatialem geospatialem mentioned this issue Sep 13, 2024
Closed
6 tasks
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Sep 14, 2024
@jcfranco jcfranco self-assigned this Sep 14, 2024
@jcfranco jcfranco mentioned this issue Sep 15, 2024
Closed
@geospatialem geospatialem mentioned this issue Sep 16, 2024
Open
6 tasks
This was referenced Sep 16, 2024
Open
Open
Closed
This was referenced Sep 25, 2024
Closed
Closed
Closed
This was referenced Sep 26, 2024
Closed
Closed
Open
@jcfranco jcfranco mentioned this issue Sep 26, 2024
Open
5 tasks
@geospatialem geospatialem mentioned this issue Sep 26, 2024
Open
5 tasks
@DitwanP
Copy link
Contributor

DitwanP commented Nov 15, 2024

Verified 🔥

@DitwanP DitwanP closed this as completed Nov 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 18, 2024
This was referenced Nov 21, 2024
Closed
Closed
Open
Closed
Closed
@DitwanP DitwanP reopened this Nov 26, 2024
@DitwanP DitwanP closed this as completed Nov 26, 2024
@github-actions github-actions bot mentioned this issue Nov 26, 2024
Closed
@jcfranco jcfranco mentioned this issue Dec 3, 2024
Merged
jcfranco added a commit that referenced this issue Dec 4, 2024
@jcfranco
fix(combobox): fix sporadic change event emitted on initialization (#…
e84ed58 
…10952)

**Related Issue:** #10731

## Summary

Tweaks initialization logic to prevent extraneous change event that
happened after #10310.
@jcfranco jcfranco mentioned this issue Dec 16, 2024
Merged
driskull added a commit that referenced this issue Dec 16, 2024
@driskull
fix: use inert on host elements instead of aria-hidden when host elem…
7ca5965 
…ent is hidden (#11056)

**Related Issue:** #10731

## Summary

This will address the following Chrome console error caused by using the
`ariaHidden` prop (after #10310):

> Blocked aria-hidden on an element because its descendant retained
focus. The focus must not be hidden from assistive technology users.
Avoid using aria-hidden on a focused element or its ancestor. Consider
using the inert attribute instead, which will also prevent focus. For
more details, see the aria-hidden section of the WAI-ARIA specification
at https://w3c.github.io/aria/#aria-hidden.
Element with focus: span
Ancestor with aria-hidden: <calcite-popover
reference-element=​"reference-element" placement=​"auto"
offset-distance=​"6" offset-skidding=​"0" text-close=​"Close"
aria-hidden=​"true" aria-live=​"polite"
id=​"calcite-popover-a872ffbb-85e1-5c2c-6f14-8108c4821728"
role=​"dialog" overlay-positioning=​"absolute" scale=​"m"
calcite-hydrated>​…​</calcite-popover>​#shadow-root (open)<div
style=​"width:​ 300px;​ padding:​12px
16px;​">​…​</div>​slot</calcite-popover>

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
This was referenced Dec 16, 2024
Closed
Open
Merged
Merged
jcfranco added a commit that referenced this issue Dec 23, 2024
@jcfranco
fix(popover, tooltip): skip ref setup logic on component removal (#11132
e67b1fe 
)

**Related Issue:** #10731

## Summary

Adds a guard to `popover` and `tooltip` `ref` callbacks to avoid missing
ref warnings on removal. After #10310, `ref` callbacks are invoked both
when the component is added and removed (see
#11093).

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
@jcfranco jcfranco mentioned this issue Dec 23, 2024
Merged
jcfranco added a commit that referenced this issue Dec 23, 2024
@jcfranco
fix(action-menu): fix toggle logic when action-menu is reconnected (#…
5874d6f 
…11139)

**Related Issue:** #10731 

## Summary

Fixes a regression caused by #10310 where the change to the internal
popover to use `triggerDisabled` would no longer work when the component
was reconnected.
@jcfranco jcfranco mentioned this issue Dec 28, 2024
Merged
jcfranco added a commit that referenced this issue Dec 28, 2024
@jcfranco
chore(linting): enable eslint-plugin-vitest (#11160)
4a1ed6e 
**Related Issue:** N/A

## Summary

This will replace `eslint-plugin-jest` rules that are no longer
applicable after #10310.
@jcfranco jcfranco mentioned this issue Dec 30, 2024
Merged
@jcfranco jcfranco mentioned this issue Jan 7, 2025
Merged
jcfranco added a commit that referenced this issue Jan 7, 2025
@jcfranco
fix(text-area): make readOnly prop writable (#11218)
0cbf766 
**Related Issue:** #11217 #10731

## Summary

Removes unintentional `@readonly` on `readOnly` prop. 

For context, with #10310 any props with the `@readonly` tag will be made
read-only.
@jcfranco jcfranco mentioned this issue Jan 15, 2025
Merged
jcfranco added a commit that referenced this issue Jan 17, 2025
@jcfranco
refactor(loadable): deprecate obsolete helpers (#11312)
4e7dc05 
**Related Issue:** #11305

## Summary

This deprecates loadable helpers to allow for incremental migration.
After #10310, `componentOnReady` is available for both lazy and
non-lazy-loading outputs, so we can replace our custom utils that
previously worked around Stencil’s inconsistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP