Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint] remove ban-props-on-host ESLint rules #10422

Closed
maxpatiiuk opened this issue Sep 27, 2024 · 5 comments
Closed

[ESLint] remove ban-props-on-host ESLint rules #10422

maxpatiiuk opened this issue Sep 27, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2024-11-26 - 3.0....

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 27, 2024 •
edited
Loading

Priority impact

p - low

Summary

Blocked by #10310

Calcite developed an ban-props-on-host ESLint rule.
Such rule is not applicable in Lumina because <Host> does not exist in Lit.

Instead, you can set props or attributes imperatively inside of connectedCallback or render.
It seems like Stencil's <Host> didn't check if attributes were already set by the user and would overwrite them. Imperatively, you can use ??= instead of = when assigning props to avoid overwriting existing value.
The codemod takes care of migrating all <Host> usages.

Desired Outcome

After migrating to Lumina, remove the ban-props-on-host ESLint rule.

Resources

No response
@maxpatiiuk maxpatiiuk added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 27, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 27, 2024
@maxpatiiuk
Copy link
Member Author

Blocked by #10310

@maxpatiiuk maxpatiiuk added the blocked This issue is blocked by another issue. label Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Closed
@jcfranco
Copy link
Member

This was addressed by #10482.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed blocked This issue is blocked by another issue. labels Nov 26, 2024
@jcfranco jcfranco removed the 0 - new New issues that need assignment. label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality breaking change Issues and pull requests with code changes that are not backwards compatible. and removed needs triage Planning workflow - pending design/dev review. labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@DitwanP
Copy link
Contributor

DitwanP commented Nov 26, 2024

🍡 Verified

@DitwanP DitwanP closed this as completed Nov 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP